Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize package and docs for log-collection library transfer #9328

Closed

Conversation

djaglowski
Copy link
Member

This PR is a first incremental step towards moving the log-collection library into this repo, as defined by #8850.

An all-in-one PR (#9227) was made, but proved to require many untracked changes. I am now taking an incremental approach as described in this comment on #9227.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 15, 2022
@djaglowski djaglowski force-pushed the init-log-collection branch 2 times, most recently from a58b980 to da59a5a Compare April 15, 2022 19:16
@djaglowski djaglowski force-pushed the init-log-collection branch from da59a5a to 00f810a Compare April 15, 2022 19:18
@djaglowski djaglowski marked this pull request as ready for review April 15, 2022 22:08
@djaglowski djaglowski requested review from a team, mx-psi and bogdandrutu April 15, 2022 22:08
@djaglowski djaglowski requested a review from pmm-sumo April 18, 2022 16:08
## What is an operator?
An operator is the most basic unit of log processing. Each operator fulfills a single responsibility, such as reading lines from a file, or parsing JSON from a field. Operators are then chained together in a pipeline to achieve a desired result.

For instance, a user may read lines from a file using the `file_input` operator. From there, the results of this operation may be sent to a `regex_parser` operator that creates fields based on a regex pattern. And then finally, these results may be sent to a `elastic_output` operator that writes each line to Elasticsearch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For instance, a user may read lines from a file using the `file_input` operator. From there, the results of this operation may be sent to a `regex_parser` operator that creates fields based on a regex pattern. And then finally, these results may be sent to a `elastic_output` operator that writes each line to Elasticsearch.
For instance, a user may read lines from a file using the `file_input` operator. From there, the results of this operation may be sent to a `regex_parser` operator that creates fields based on a regex pattern. And then finally, these results may be sent to a `stdout` operator that writes each line to stdout.

This is probably minor, but elastic is no longer included among the outputs. Also, I'm wondering if we should describe that the library is used in the receiver which means it does not need to use outputs normally

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feedback, this doc is quite out of date. I took a pass through the document and updated the contents to reflect the current state much more accurately.

@@ -0,0 +1,46 @@
## What is an operator?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could add a status describing that the library move is in progress?

Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, otherwise LGTM

@bogdandrutu
Copy link
Member

@djaglowski one approach we did when moved lots of core components to contrib, was to move everything using git subtree to save history, and explicitly remove that module from the "Makefile" build/test/checks until we were done with it. The beauty was that we saved the entire history of commits.

@djaglowski
Copy link
Member Author

@djaglowski one approach we did when moved lots of core components to contrib, was to move everything using git subtree to save history, and explicitly remove that module from the "Makefile" build/test/checks until we were done with it. The beauty was that we saved the entire history of commits.

This sounds like a better approach. I'll look into it.

@djaglowski
Copy link
Member Author

I'm converting this back to a draft until Bogdan's suggested approach is looked into.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 4, 2022
@djaglowski
Copy link
Member Author

Closing in favor of #9376

@djaglowski djaglowski closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants