[cmd/mdatagen] Allow attribute values of any types #9245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
abhide
commented
May 2, 2022
dmitryax
approved these changes
May 3, 2022
abhide
changed the title
|
Actually this is not it. There are several other places where the templating needs to be updated:
|
thanks @dmitryax I will look into this and send out a fix |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Any update on this? Would be great to get this change in. |
@djaglowski Yes, working on it. Should have it in by end of this week. |
abhide
force-pushed
the
GH-8127
branch
2 times, most recently
from
56ebba5 to
4ae19e5
Compare
abhide
force-pushed
the
GH-8127
branch
2 times, most recently
from
eb241a3 to
8bbefa9
Compare
abhide
commented
Jun 8, 2022
receiver/vcenterreceiver/internal/metadata/generated_metrics_v2.go
Outdated
Show resolved
Hide resolved
djaglowski
changed the title
dmitryax
approved these changes
Jun 10, 2022
dmitryax
added
the
ready to merge
djaglowski
approved these changes
Jun 13, 2022
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
* WIP: Allow attribute values of any types * Update all_options.yaml * Update metric-metadata.yaml * Update CHANGELOG.md * Fixes * Fixes * Fix CHANGELOG.md Co-authored-by: Dmitrii Anoshin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: #8127
Testing:
Documentation: