[prometheus components] For histograms without sums, leave the sum unset #9120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
histogram_without_sum
branch
from
bece4ab to
4f00b37
Compare
Aneurysm9
reviewed
Apr 13, 2022
dashpole
force-pushed
the
histogram_without_sum
branch
5 times, most recently
from
d89f35f to
f9ed2cf
Compare
dashpole
force-pushed
the
histogram_without_sum
branch
from
f9ed2cf to
a3412c8
Compare
|
cc @open-telemetry/wg-prometheus |
dashpole
force-pushed
the
histogram_without_sum
branch
from
a3412c8 to
1ccf7cd
Compare
dashpole
force-pushed
the
histogram_without_sum
branch
from
1ccf7cd to
cccfb37
Compare
dashpole
force-pushed
the
histogram_without_sum
branch
from
cccfb37 to
95f1023
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dashpole
force-pushed
the
histogram_without_sum
branch
from
b87e925 to
a002e3f
Compare
dashpole
force-pushed
the
histogram_without_sum
branch
2 times, most recently
from
80dd729 to
7a50abd
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dashpole
force-pushed
the
histogram_without_sum
branch
from
7a50abd to
8b58c4e
Compare
dashpole
force-pushed
the
histogram_without_sum
branch
from
6d4618f to
b47f248
Compare
pichlermarc
approved these changes
Aug 8, 2022
dashpole
force-pushed
the
histogram_without_sum
branch
from
b47f248 to
40950ed
Compare
dashpole
added
receiver/prometheus
Aneurysm9
approved these changes
Aug 25, 2022
dashpole
added
the
ready to merge
bogdandrutu
reviewed
Aug 30, 2022
dashpole
force-pushed
the
histogram_without_sum
branch
2 times, most recently
from
ca3b768 to
5ce3746
Compare
|
@dashpole needs a rebase, sorry for the issue. |
…hout sums, leave the sum unset
dashpole
force-pushed
the
histogram_without_sum
branch
from
5ce3746 to
d9663d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Prometheus histograms don't have a sum if the histogram includes negative observations. Now that the protocol supports a notion of "unset" sums, use this in prometheus components to correctly handle setting the sum.
I tried to do this for the prometheus exporter as well, but NewConstHistogram requires a sum (i.e. doesn't support an unset sum). https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/prometheusexporter/collector.go#L200
Link to tracking Issue:
Part of #7546
Testing:
Added unit tests.