Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Add host_metadata section #9100

Merged
merged 7 commits into from
Apr 11, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 6, 2022

Description:

Add host_metadata section to group related settings.

Link to tracking Issue: #9099

Testing:

  • Added unit tests
  • Check that deprecation warnings are logged
  • Test that host metadata keeps being sent when only_metadata is false (not covered by tests)

Documentation: Updated documentation

exporter/datadogexporter/example/config.yaml Outdated Show resolved Hide resolved
exporter/datadogexporter/example/config.yaml Outdated Show resolved Hide resolved
exporter/datadogexporter/config/config.go Outdated Show resolved Hide resolved
@mx-psi mx-psi marked this pull request as ready for review April 7, 2022 14:22
@mx-psi mx-psi requested review from a team and bogdandrutu April 7, 2022 14:22
@jpkrohling
Copy link
Member

I trust @mx-psi, but would it be possible to get an approval from another code owner as well? Like @KSerrania, @gbbr or @knusbaum

@mx-psi
Copy link
Member Author

mx-psi commented Apr 7, 2022

@jpkrohling Sure, I will ask internally for this

Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions about comments, overall LGTM

exporter/datadogexporter/config/config.go Outdated Show resolved Hide resolved
exporter/datadogexporter/config/config.go Outdated Show resolved Hide resolved
exporter/datadogexporter/example/config.yaml Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member Author

mx-psi commented Apr 11, 2022

This is ready to merge, but I am babysitting the CI until I finally get a test run without flakes

@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Apr 11, 2022
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving on behalf of the other reviews, done by code owners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants