-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadog] Add host_metadata
section
#9100
Conversation
Co-authored-by: Albert Vaca Cintora <[email protected]>
I trust @mx-psi, but would it be possible to get an approval from another code owner as well? Like @KSerrania, @gbbr or @knusbaum |
@jpkrohling Sure, I will ask internally for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions about comments, overall LGTM
Co-authored-by: Kylian Serrania <[email protected]>
This is ready to merge, but I am babysitting the CI until I finally get a test run without flakes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving on behalf of the other reviews, done by code owners.
Description:
Add
host_metadata
section to group related settings.Link to tracking Issue: #9099
Testing:
only_metadata
is false (not covered by tests)Documentation: Updated documentation