Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/prometheusexec] mark receiver as deprecated #9058

Merged

Conversation

codeboten
Copy link
Contributor

After many discussions it seems the community is leaning towards removing the components that execute subprocesses. As such, marking the prom_exec receiver as deprecated.

Related to: #6722

If folks are ok with this path moving forward, I can follow this up with a PR to remove the component from the manifest in the releases repository in the next version.

After many discussions it seems the community is leaning towards removing the components that execute subprocesses. As such, marking the prom_exec receiver as deprecated.

Fixes open-telemetry#6722
@codeboten codeboten requested a review from a team April 4, 2022 18:23
@codeboten codeboten requested a review from dmitryax as a code owner April 4, 2022 18:23
Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpkrohling jpkrohling merged commit a434fd3 into open-telemetry:main Apr 6, 2022
@mx-psi
Copy link
Member

mx-psi commented Apr 6, 2022

As with other components, I think this should also come with a deprecation on the go.mod itself

@codeboten codeboten deleted the codeboten/deprecate-promexec branch June 8, 2022 18:42
TylerHelmuth added a commit that referenced this pull request Aug 3, 2023
…24740)

**Description:**
Removes the deprecated prometheus_exec receiver. This component was
[deprecated over a year
ago](#9058),
even before our now [documented `two minor
releases`](https://github.com/open-telemetry/opentelemetry-collector#deprecated)
timeline.

**Link to tracking Issue:** <Issue number if applicable>

Related to
#6722

**Testing:**
Confirmed `make otelcontribcol` works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants