Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update otel core #8821

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

codeboten
Copy link
Contributor

Follow up to open-telemetry/opentelemetry-collector#5066:
Rename Array type of pdata.Value to Slice

  • Deprecate pdata.AttributeValueTypeArray type in favor of pdata.ValueTypeSlice
  • Deprecate pdata.NewAttributeValueArray func in favor of pdata.NewValueSlice

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Follow up to open-telemetry/opentelemetry-collector#5066:
  Rename `Array` type of `pdata.Value` to `Slice`
  - Deprecate `pdata.AttributeValueTypeArray` type in favor of `pdata.ValueTypeSlice`
  - Deprecate `pdata.NewAttributeValueArray` func in favor of `pdata.NewValueSlice`
@codeboten codeboten requested a review from a team March 23, 2022 22:15
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 23, 2022
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it

@codeboten codeboten merged commit 15cae21 into open-telemetry:main Mar 24, 2022
@codeboten codeboten deleted the codeboten/update-otel-mar23 branch March 24, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants