Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/skywalking] add Skywalking tracing receiver impl #8549

Merged
merged 26 commits into from
Mar 21, 2022
Merged

[receiver/skywalking] add Skywalking tracing receiver impl #8549

merged 26 commits into from
Mar 21, 2022

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented Mar 18, 2022

Description: add Skywalking tracing receiver impl

  1. impl skywalking grpc/http channel to receiver skywalking agent tracing data.
  2. dummy response skywalking's grpc service.

Link to tracking Issue: #7954

Testing: tested with following steps:

  1. otel config yaml:
receivers:
  # The following demonstrates how to enable protocols with defaults.
  skywalking/defaults:
    protocols:
      grpc:
  skywalking:
    protocols:
      grpc:
        endpoint: 0.0.0.0:11800
      http:
        endpoint: 0.0.0.0:12800
  skywalking/customname:
    protocols:
      http:
        endpoint: 0.0.0.0:12801

exporters:
  jaeger:
    endpoint: "jaeger:14250"
    tls:
      insecure: true

processors:
  batch:

service:
  pipelines:
    traces:
      receivers: [skywalking]
      processors: [batch]
      exporters: [jaeger]
  1. jaeger ui tracing view:

image

image

Documentation:

@JaredTan95 JaredTan95 requested review from a team and Aneurysm9 March 18, 2022 13:03
@JaredTan95 JaredTan95 changed the title add Skywalking tracing receiver impl [receiver/skywalking] add Skywalking tracing receiver impl Mar 18, 2022
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
@dashpole
Copy link
Contributor

cc @jpkrohling, who I believe is sponsoring the component

@jpkrohling jpkrohling self-requested a review March 18, 2022 18:46
JaredTan95 and others added 7 commits March 19, 2022 09:14
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>

# Conflicts:
#	receiver/apachereceiver/internal/metadata/generated_metrics.go
#	receiver/couchdbreceiver/internal/metadata/generated_metrics.go
#	receiver/elasticsearchreceiver/internal/metadata/generated_metrics.go
#	receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/internal/metadata/generated_metrics.go
#	receiver/hostmetricsreceiver/internal/scraper/loadscraper/internal/metadata/generated_metrics.go
#	receiver/hostmetricsreceiver/internal/scraper/memoryscraper/internal/metadata/generated_metrics.go
#	receiver/hostmetricsreceiver/internal/scraper/networkscraper/internal/metadata/generated_metrics.go
#	receiver/hostmetricsreceiver/internal/scraper/pagingscraper/internal/metadata/generated_metrics.go
#	receiver/hostmetricsreceiver/internal/scraper/processscraper/internal/metadata/generated_metrics.go
#	receiver/mysqlreceiver/internal/metadata/generated_metrics.go
#	receiver/nginxreceiver/internal/metadata/generated_metrics.go
#	receiver/postgresqlreceiver/internal/metadata/generated_metrics.go
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
#3870

Signed-off-by: jian.tan <[email protected]>
@jpkrohling jpkrohling merged commit 459a4bc into open-telemetry:main Mar 21, 2022
@JaredTan95 JaredTan95 deleted the sw_receiver_impl branch March 21, 2022 14:43
@caoheyang
Copy link

caoheyang commented Mar 26, 2022

Hi Jared,

@JaredTan95 I have a quick question, when I want to use skywalking tracing receiver, should I use opentelemetry agent for java or skywalking agent for java?

Thanks,

Heyang

@JaredTan95
Copy link
Member Author

skywalking agent

@caoheyang
Copy link

Thanks, Jared,
So ,how to use opentelemetry-collector receiver the skywalking trace info?
export anothor port for opentelemetry-collecto?

Heyang

@JaredTan95
Copy link
Member Author

As described by #8549 (comment):

receivers:
  skywalking:
    protocols:
      grpc:
        endpoint: 0.0.0.0:11800
      http:
        endpoint: 0.0.0.0:12800

exporters:
  jaeger:
    endpoint: "jaeger:14250"
    tls:
      insecure: true

processors:
  batch:

service:
  pipelines:
    traces:
      receivers: [skywalking]
      processors: [batch]
      exporters: [jaeger]

You shuold add skywalking receiver, and then, you can change the Skywalking OAP Address to otel collecotr 11800 port in skywalking agent config.

@caoheyang
Copy link

OKay, Thanks a lot ,Jared, I will try it.

Regards,
Heyang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants