Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Add metrics::sums::cumulative_monotonic_mode setting; deprecate metrics::send_monotonic_counter #8490

Merged
merged 8 commits into from
Mar 25, 2022
Merged

[exporter/datadog] Add metrics::sums::cumulative_monotonic_mode setting; deprecate metrics::send_monotonic_counter #8490

merged 8 commits into from
Mar 25, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 15, 2022 •
edited
Loading

Description:

  • Add scaffolding for renaming configuration options.
  • Add new metrics::sums::cumulative_monotonic_mode setting.
  • Deprecate metrics::send_monotonic_counter in favor of metrics::sums::cumulative_monotonic_mode

Link to tracking Issue: #8489

Testing:

  • Add unit tests to check that warning is emitted when using the deprecated setting
  • Add unit test to check that an error results from using deprecated + new at the same time

Documentation: Update the template

@mx-psi mx-psi changed the title [exporter/datadog] Add metrics::sum::mode setting; deprecate metrics::send_monotonic_counter [exporter/datadog] Add metrics::sum::cumulative_monotonic_mode setting; deprecate metrics::send_monotonic_counter Mar 16, 2022
@mx-psi mx-psi changed the title [exporter/datadog] Add metrics::sum::cumulative_monotonic_mode setting; deprecate metrics::send_monotonic_counter [exporter/datadog] Add metrics::sums::cumulative_monotonic_mode setting; deprecate metrics::send_monotonic_counter Mar 18, 2022
@mx-psi mx-psi force-pushed the mx-psi/metrics-sum-mode branch from 5c3da0e to 7e6a14c Compare March 18, 2022 12:04
@mx-psi mx-psi marked this pull request as ready for review March 22, 2022 09:38
@mx-psi mx-psi requested review from a team and Aneurysm9 March 22, 2022 09:38
@mx-psi mx-psi mentioned this pull request Mar 22, 2022
Merged
14 tasks
KSerrania
KSerrania approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation system looks good to me.

exporter/datadogexporter/config/warning_deprecated.go Show resolved Hide resolved
exporter/datadogexporter/config/warning_deprecated.go Outdated Show resolved Hide resolved
@mx-psi mx-psi added ready to merge Code review completed; ready to merge by maintainers and removed ready to merge Code review completed; ready to merge by maintainers labels Mar 24, 2022
@mx-psi mx-psi mentioned this pull request Mar 25, 2022
Merged
@jpkrohling jpkrohling merged commit c2e9a91 into open-telemetry:main Mar 25, 2022
@mx-psi mx-psi deleted the mx-psi/metrics-sum-mode branch March 25, 2022 15:01
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSerrania KSerrania KSerrania approved these changes

@anuraaga anuraaga anuraaga approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@anuraaga anuraaga

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mx-psi @anuraaga @KSerrania @jpkrohling