Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/splunkhec] Add validation for sending_queue setting #8256

Merged
merged 9 commits into from
Mar 7, 2022
Merged

[exporter/splunkhec] Add validation for sending_queue setting #8256

merged 9 commits into from
Mar 7, 2022

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented Mar 4, 2022 •
edited
Loading

Description: Add validation for sending_queue setting

Link to tracking Issue: Resolves #7844

Testing:

Documentation:

@JaredTan95 JaredTan95 requested a review from a team March 4, 2022 01:49
@JaredTan95 JaredTan95 requested a review from dmitryax as a code owner March 4, 2022 01:49
dmitryax
dmitryax approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JaredTan95

@jpkrohling jpkrohling merged commit 82b0394 into open-telemetry:main Mar 7, 2022
@JaredTan95 JaredTan95 mentioned this pull request May 20, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@anuraaga anuraaga anuraaga approved these changes

Assignees

@anuraaga anuraaga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[exporter/splunkhec] Ensure Validate implementation does the right thing
4 participants
@JaredTan95 @anuraaga @dmitryax @jpkrohling