Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/tanzuobservability]Instrumentation Library and Dropped Counts to Span Tags #8120

Merged
merged 9 commits into from
Mar 9, 2022
Merged

[exporter/tanzuobservability]Instrumentation Library and Dropped Counts to Span Tags #8120

merged 9 commits into from
Mar 9, 2022

Conversation

deosu
Copy link
Contributor

@deosu deosu commented Feb 24, 2022

Description: Add following span-tags:
otel.dropped_events_count
otel.dropped_links_count
otel.dropped_attributes_co
otel.span.name
otel.span.version

Link to tracking Issue: N/A

Testing: Unit and manual testing

Documentation: N/A

@deosu
Add new span-tags.
61b0ee7 
Add following span-tags:
otel.dropped_events_count
otel.dropped_links_count
otel.dropped_attributes_co
otel.span.name
otel.span.version
@deosu
Update CHANGELOG.md
e8186e3 
Add instrumentation Library and Dropped Counts to Span Tags.
keep94
keep94 suggested changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@keep94 keep94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sumit. Thank you for doing this work. Just a few minor comments.

exporter/tanzuobservabilityexporter/exporter.go Outdated Show resolved Hide resolved
exporter/tanzuobservabilityexporter/exporter.go Outdated Show resolved Hide resolved
exporter/tanzuobservabilityexporter/exporter.go Outdated Show resolved Hide resolved
exporter/tanzuobservabilityexporter/transformer.go Outdated Show resolved Hide resolved
exporter/tanzuobservabilityexporter/transformer_test.go Show resolved Hide resolved
exporter/tanzuobservabilityexporter/exporter_test.go Outdated Show resolved Hide resolved
keep94
keep94 suggested changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@keep94 keep94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks sumit, just one more thing. Will you use different numbers in your tests for the different tags? That way you are sure that your code under test is matching the correct attribute to the correct tag name.

exporter/tanzuobservabilityexporter/transformer_test.go Outdated Show resolved Hide resolved
exporter/tanzuobservabilityexporter/transformer_test.go Outdated Show resolved Hide resolved
@deosu deosu marked this pull request as ready for review February 25, 2022 01:16
@deosu deosu requested review from a team and codeboten February 25, 2022 01:16
@deosu
Copy link
Contributor Author

deosu commented Feb 25, 2022

Merged lastest changes from the main branch.

codeboten
codeboten reviewed Feb 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@deosu @codeboten
Update CHANGELOG.md
16e3f10 
Co-authored-by: Alex Boten <[email protected]>
@deosu deosu requested a review from codeboten March 7, 2022 06:29
@deosu
Copy link
Contributor Author

deosu commented Mar 7, 2022

@codeboten please review.

@deosu
Copy link
Contributor Author

deosu commented Mar 9, 2022

@codeboten the unit test failure does not look like related to our changes. Failure: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/5470161638?check_suite_focus=true

@jpkrohling
Copy link
Member

The tests are now passing.

@codeboten codeboten merged commit 4ea0755 into open-telemetry:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keep94 keep94 keep94 approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@djaglowski djaglowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deosu @jpkrohling @codeboten @keep94 @djaglowski