Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/skywalking] Create skywalking component folder/structure #8107

Merged
merged 40 commits into from
Mar 2, 2022
Merged

[receiver/skywalking] Create skywalking component folder/structure #8107

merged 40 commits into from
Mar 2, 2022

Conversation

JaredTan95
Copy link
Member

Description:

1st PR: Create skywalking component folder/structure and finish factory , config unit test.

Link to tracking Issue: #7954
Testing:

Documentation:
added skywalking receiver README.md

@pmm-sumo pmm-sumo requested a review from jpkrohling February 23, 2022 08:37
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
@JaredTan95
Copy link
Member Author

thanks @pmm-sumo again

Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good for the first phase now. Lets see what @jpkrohling and others say :)

@jpkrohling
Copy link
Member

This is also failing:

Using versioning file /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/versions.yaml
verifyAllModulesInSet failed: Module github.com/open-telemetry/opentelemetry-collector-contrib/receiver/skywalkingreceiver (defined in /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/skywalkingreceiver/go.mod) is not listed in any module set.

Please, go over the contribution guidelines and check which files need to be changed for new components.

@JaredTan95
Copy link
Member Author

This is also failing:

Using versioning file /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/versions.yaml
verifyAllModulesInSet failed: Module github.com/open-telemetry/opentelemetry-collector-contrib/receiver/skywalkingreceiver (defined in /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/skywalkingreceiver/go.mod) is not listed in any module set.

Please, go over the contribution guidelines and check which files need to be changed for new components.

I did not change it , especially. because this is the 1st PR and the receiver does not fully functional.
I will update this, thanks.

Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
@jpkrohling jpkrohling merged commit 91a96cd into open-telemetry:main Mar 2, 2022
@JaredTan95 JaredTan95 deleted the sw_reciever branch March 2, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants