[processor / spanmetricsprocessor] dropping the condition to replace _ with key_ as __ is reserved and _ is not #8057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
featureGate changes for sanitizing labels that start with `_`
|
@codeboten @Aneurysm9, since you reviewed the other related PRs, could you have a look at this one? |
mx-psi
reviewed
Feb 22, 2022
There was a problem hiding this comment.
I will defer to @codeboten and @Aneurysm9 opinions, but I think adding Prometheus-specific logic to a component that is, in principle, independent of Prometheus, is an anti-pattern that should be avoided
updated the feature gate identifier
…ishna397/opentelemetry-collector-contrib into spanmetricsprocessor_issue
changelog update
|
@Aneurysm9 , @mx-psi could you please review and let me know if there're any changes pending. |
dropped processor helper import in factory.go
Aneurysm9
approved these changes
Mar 4, 2022
mx-psi
approved these changes
Mar 4, 2022
codeboten
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: when sanitizeLabel feature flag is enabled, labels that start with _ are not updated. labels that start with __ are sanitized irrespective of this flag since __ is reserved in prometheus and _ is not.
followed the same approach as #7112 & #7506
Link to tracking Issue:
Testing: emit a metric that has a label starting with _ and it should not be prefixed with key when skipSanitizeLabel is enabled.
Documentation: