Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prometheus Receiver] Adding testcase to validate normalNaNs passthrough #6710

Merged

Conversation

PaurushGarg
Copy link
Member

Description:

  • Adding testcases to validate passthrough of normalNaN.

Link to tracking Issue:
Issue #6087

@PaurushGarg PaurushGarg requested a review from a team December 11, 2021 06:11
@Aneurysm9 Aneurysm9 added the ready to merge Code review completed; ready to merge by maintainers label Dec 14, 2021
@bogdandrutu
Copy link
Member

"This branch has conflicts that must be resolved" please rebase

@bogdandrutu bogdandrutu enabled auto-merge (squash) December 14, 2021 19:29
@bogdandrutu
Copy link
Member

"This branch has conflicts that must be resolved" please rebase

auto-merge was automatically disabled December 15, 2021 03:33

Head branch was pushed to by a user without write access

@PaurushGarg
Copy link
Member Author

"This branch has conflicts that must be resolved" please rebase

I have now resolved the conflict. Thanks.

@bogdandrutu bogdandrutu merged commit f60ea59 into open-telemetry:main Dec 16, 2021
@PaurushGarg PaurushGarg deleted the prom-receiver-test-normal-nan-2 branch December 18, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants