-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare v0.40.0 #6428
Prepare v0.40.0 #6428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this PR wait until the 0.40.0 tag is completed in core?
This is the first step in the release doc, I suppose this is only to make sure the current collector core won't break contrib. It does say to get this reviewed/merged though :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 somewhat surprised this broke the correctness tests
Ah i see, i missed this change: open-telemetry/opentelemetry-collector@62a6552 |
I just added a new commit to this PR, fixing the change from GetStateChannel to GetState. |
Looks like the prometheus change broke the tests
|
True, I just restarted the test thinking it was a flaky test, but I need to look deeper into this. |
70ccb44
to
258f999
Compare
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
258f999
to
aa45736
Compare
I fixed the Prometheus tests and a couple of missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw your message on Slack, wanted to say it looks good even if already merged :)
Thanks! I wasn't sure someone was working today :-) |
Closes open-telemetry/opentelemetry-collector#4477
Closes open-telemetry/opentelemetry-collector#4480
Signed-off-by: Juraci Paixão Kröhling [email protected]