Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signalfx exporter: add translation for statefulset dimensions #640

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Aug 3, 2020

No description provided.

@dmitryax dmitryax requested a review from a team August 3, 2020 21:51
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #640 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #640   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files         195      195           
  Lines       10632    10632           
=======================================
  Hits         9172     9172           
  Misses       1128     1128           
  Partials      332      332           
Flag Coverage Δ
#integration 71.09% <ø> (ø)
#unit 86.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea311f3...d4308c3. Read the comment docs.

@dmitryax dmitryax force-pushed the sfx-add-statefullset-translations branch from 279a1f9 to d4308c3 Compare August 3, 2020 23:41
@bogdandrutu bogdandrutu merged commit ea019fc into open-telemetry:master Aug 3, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Add metric helper package to internal/process that adds a MatchMetric function that can be used by processors to filter metrics by metric name. MatchMetric can be extended to match on additional metric properties down the line.

`import "github.com/open-telemetry/opentelemetry-collector/internal/processor/metric"`

In addition
- Add a Factory class for creating FilterSets easily
- Add "testutils/configtestutils" to help with testing yaml configs of subpackages

**Link to tracking Issue:** Second part of Filter Processor Proposal #560, though the package can be used by other processors too

**Testing:** Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants