Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported kinesis exporter from Omnition #60

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Ported kinesis exporter from Omnition #60

merged 1 commit into from
Dec 13, 2019

Conversation

owais
Copy link
Contributor

@owais owais commented Dec 11, 2019

Porting the existing kinesis exporter from Omnition's Otel distribution
to contrib.

Porting from: https://github.com/Omnition/omnition-opentelemetry-collector/tree/master/exporter/kinesis

Currently exports to Kinesis in Jaeger proto format only. Support for other formats can be added later.

@owais
Copy link
Contributor Author

owais commented Dec 11, 2019

Looking at CI failures.

tigrannajaryan
tigrannajaryan approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had reviewed this code earlier in its original repo, approving.

go.mod
@@ -22,3 +24,5 @@ require (
replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/azuremonitorexporter v0.0.0 => ./exporter/azuremonitorexporter

replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/sapmexporter => ./exporter/sapmexporter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these "replace" directives that are no longer needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can but first we need to merge this or we'll need another PR I think. #59

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of prefer to go in two PRs but up to you.

pjanotti
pjanotti approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be nice to comment on the configuration fields but due to the number of them let's do it separately. I also had looked at this code before but tried to look again... single nit, LGTM.

exporter/kinesisexporter/config_test.go

func TestConfigCheck(t *testing.T) {
cfg := (&Factory{}).CreateDefaultConfig()
assert.NoError(t, configcheck.ValidateConfig(cfg))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

exporter/kinesisexporter/config.go Outdated
type KPLConfig struct {
AggregateBatchCount int `mapstructure:"aggregate_batch_count"`
AggregateBatchSize int `mapstructure:"aggregate_batch_size"`
BatchSize int `mapstructure:"batch_size, omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove omitempty

go.mod
@@ -22,3 +24,5 @@ require (
replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/azuremonitorexporter v0.0.0 => ./exporter/azuremonitorexporter

replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/sapmexporter => ./exporter/sapmexporter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of prefer to go in two PRs but up to you.

@owais
Ported kinesis exporter from Omnition
b76e3cd 
Porting the existing kinesis exporter from Omnition's Otel distribution
to contrib.

Porting from: https://github.com/Omnition/omnition-opentelemetry-collector/tree/master/exporter/kinesis
@owais
Copy link
Contributor Author

owais commented Dec 12, 2019

Updated.

@tigrannajaryan tigrannajaryan merged commit af8a37b into open-telemetry:master Dec 13, 2019
@owais owais deleted the port-kinesis-build branch December 13, 2019 12:32
pjanotti pushed a commit that referenced this pull request Dec 16, 2019
@kbrockhoff
Add AWS X-Ray Exporter (#41)
2b856d9 
* initial def of aws xray exporter

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of export handler

* fix formatting and lint errors

* initial dev of export handler

* added to component list

* fix issues raised during code review

* switch user attribute name to constant

* fixed additional code review issues

* fixed additional code review issues

* temporarily change package name

* temporarily change package name

* revert temporarily change package name

* fixed additional code review issues

* switched to constants defined in collector

* switched to status conversion functions defined in collector

* fix latest code review issues

* fix new static check issues

* fix test that breaks if no valid aws session available

* Update Collector Core dependency to latest `master` (#61)

- Updated go.mod and testbed/go.mod to point to latest `master` commit
  for github.com/open-telemetry/opentelemetry-collector dependencies and
  fixed the code as needed.
- Run `go mod tidy` on both go.mod files.

* Ported kinesis exporter from Omnition (#60)

Porting the existing kinesis exporter from Omnition's Otel distribution
to contrib.

Porting from: https://github.com/Omnition/omnition-opentelemetry-collector/tree/master/exporter/kinesis

* fix pull request issues

* Updated SAPM exporter dependencies (#59)

* Add E2E test for SAPM Receiver (#63)

- Added DataSender for SAPM protocol.
- Added SAPM protocol receiver test to TestTrace10K scenario.

* Updated component dependencies (#64)

* Fix build for go 1.13 (#65)

* Add E2E test for SAPM Exporter (#66)

SAPM trace test was using SAPM Receiver and Jaeger Exporter.
Now SAPM is used for both ends.

* initial def of aws xray exporter

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of xray data structures and converters

* initial dev of export handler

* fix formatting and lint errors

* initial dev of export handler

* added to component list

* fix issues raised during code review

* switch user attribute name to constant

* fixed additional code review issues

* fixed additional code review issues

* temporarily change package name

* temporarily change package name

* revert temporarily change package name

* fixed additional code review issues

* switched to constants defined in collector

* switched to status conversion functions defined in collector

* fix latest code review issues

* fix new static check issues

* fix test that breaks if no valid aws session available

* fix pull request issues
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@rghetia
add APIs for traceoption and tracestate. (#60)
0edf31e 
* add APIs for traceoption and tracestate.

* remove tracestate and refactor traceoptions.
bogdandrutu pushed a commit that referenced this pull request May 12, 2022
@wph95
use opentelemetry collect standard tls config instead of tc tls config (
aa8d825 
#60)

* use opentelemetry collect standard tls config instead of tc tls config
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this pull request Jun 2, 2022
@crearys
Update to collector v0.31.0 (open-telemetry#60)
f6a5144
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this pull request Jun 2, 2022
@jpkrohling @bogdandrutu
@joe-elliott @jiwen624 @Ashmita152 @fangyi-zhou @crearys @pmalek-sumo @secat @sodabrew @pmalek @KKelvinLo @himanshu007-creator @u5surf @zchee @Aneurysm9 @loomis-relativity
Move opentelemetry-collector-builder to core (open-telemetry#4286)
4063a46 
* Initial commit

* Add CODEOWNERS file (open-telemetry#2)

* Add CODEOWNERS file

* Update CODEOWNERS

* Moved from github.com/observatorium/opentelemetry-collector-builder (open-telemetry#3)

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* fixed panics (open-telemetry#6)

Signed-off-by: Joe Elliott <[email protected]>

* Replace master with main in CI and mergify files (open-telemetry#8)

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Bump to OpenTelemetry Collector 0.20.0 (open-telemetry#10)

Closes open-telemetry#9

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Explicitly enable Go modules in quickstart instructions (open-telemetry#13)

* Update to collector v0.21.0 (open-telemetry#17)

Fixes open-telemetry#16

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Update to collector v0.22.0 (open-telemetry#19)

* Download go modules before building (open-telemetry#20)

Fixes open-telemetry#14

* Add version command (open-telemetry#25)

Signed-off-by: Ashmita Bohara <[email protected]>

* Pass errors from cobra Execute back to main for correct exit code (open-telemetry#28)

* pass errors from cobra execute back to main

* print the error

* Update to collector v0.23.0 (open-telemetry#27)

* Generate a warning if the builder and collector base version mismatch (open-telemetry#30)

* Generate a warning if the builder and collector base version mismatch

* Show current default version in the warning message

* Update to OpenTelemetry Collector 0.24.0

* Don't use %w formatting with log.Fatal (open-telemetry#35)

* Update to OpenTelemetry Collector 0.25.0 (open-telemetry#36)

Signed-off-by: Serge Catudal <[email protected]>

* Update to 0.26.0 and update BuildInfo (open-telemetry#39)

* Sync build and CI Go versions at latest 1.16 (open-telemetry#34)

* Sync build and CI Go versions at latest 1.16

* Run go mod tidy

* Set go binary to use in the compilation phase in tests

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* Add option to generate go code only (no compile) (open-telemetry#40)

* Issue#24 Add option to generate go code only (no compile)

* Update cmd/root.go logging

Suggested by @jpkkrohling

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* remove verbose help .. created by corba

* suggestion by jpkrohling to keep generateandcompile

* lint error: remove unused var

* reword cmd option and add back help message for default

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* Don't reuse exec.Cmd (open-telemetry#42)

* Update to OpenTelemetry Collector 0.27.0 (open-telemetry#43)

* Add CI Badge (open-telemetry#47)

* Update to Collector v0.28.0 (open-telemetry#49)

* Update to Collector v0.28.0

Closes open-telemetry#48

Addresses the breaking API change in
open-telemetry/opentelemetry-collector#3163,
besides the usual version number changes.

Signed-off-by: Fangyi Zhou <[email protected]>

* Use `go mod tidy` instead of `go mod download`

It appears that this magically resolves the go.mod file issue.
https://stackoverflow.com/questions/67203641/missing-go-sum-entry-for-module-providing-package-package-name

Signed-off-by: Fangyi Zhou <[email protected]>

* Account for go mod download in go1.17 not updating go.sum (open-telemetry#50)

* Update to collector v0.29.0 (open-telemetry#54)

* Update replaces.builder.yaml

* Update nocore.builder.yaml

* Update config.go

* Update README.md

* Update main.go

* Update to collector v0.30.0 (open-telemetry#57)

* cmd: fix module flag default value to github.com/open-telemetry (open-telemetry#58)

Signed-off-by: Koichi Shiraishi <[email protected]>

* Update to collector v0.31.0 (open-telemetry#60)

* Update to v0.33.0 (open-telemetry#62)

Signed-off-by: Anthony J Mirabella <[email protected]>

* Add excludes support to generated go.mod (open-telemetry#63)

Signed-off-by: Anthony J Mirabella <[email protected]>

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* Small cleanup for the builder files (open-telemetry#64)

Signed-off-by: Bogdan Drutu <[email protected]>

* Support building with Go 1.17 (open-telemetry#66)

* Support building with Go 1.17
Fixes open-telemetry#65

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Update workflows to use Go 1.17

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Add gosec exceptions for exec.Command

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Update to OpenTelemetry core 0.34.0 (open-telemetry#68)

Fixes open-telemetry#67

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Upgrade to OpenTelemetry Collector 0.35.0 (open-telemetry#70)

Signed-off-by: Fangyi Zhou <[email protected]>

* Upgrade to OpenTelemetry Collector 0.36.0 (open-telemetry#76)

* Generate custom service code for Windows (open-telemetry#75)

* update main to include windows service code

* use main version from tag 0.35.0

* update main function

* align with upstream v0.36.0 tag

* dummy change to trigger build

* Revert "dummy change to trigger build"

This reverts commit 629d499461da2d2c240bf1e495b5fe0558e3547f.

* Remove Core from Module type (open-telemetry#77)

Fixes open-telemetry#15

Signed-off-by: yugo-horie <[email protected]>

* release 0.37.0 (open-telemetry#78)

* release 0.37.0

* update use of NewCommand

* Move builder to subdirectory

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

Co-authored-by: Bogdan Drutu <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
Co-authored-by: Joe Elliott <[email protected]>
Co-authored-by: Eric Yang <[email protected]>
Co-authored-by: Brian Gibbins <[email protected]>
Co-authored-by: Ashmita <[email protected]>
Co-authored-by: Fangyi Zhou <[email protected]>
Co-authored-by: Shaun Creary <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Co-authored-by: Serge Catudal <[email protected]>
Co-authored-by: Aaron Stone <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Co-authored-by: Aaron Stone <[email protected]>
Co-authored-by: Kelvin Lo <[email protected]>
Co-authored-by: Himanshu <[email protected]>
Co-authored-by: Y.Horie <[email protected]>
Co-authored-by: Koichi Shiraishi <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Co-authored-by: Cal Loomis <[email protected]>
Co-authored-by: alrex <[email protected]>
jj22ee pushed a commit to jj22ee/opentelemetry-collector-contrib that referenced this pull request Sep 21, 2023
@chadpatel
Merge pull request open-telemetry#60 from chadpatel/patchad-concurren…
f675755 
…t-map-write-fix

fix concurrent map write crash in podstore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanotti pjanotti pjanotti approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@flands flands Awaiting requested review from flands

@rghetia rghetia Awaiting requested review from rghetia

@songy23 songy23 Awaiting requested review from songy23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owais @tigrannajaryan @pjanotti