Added new redis.instance resource attribute and config parameter #5922
Conversation
|
|
manang-splunk
changed the title
| require.NoError(t, err) | ||
| md, err := runner.Scrape(context.Background()) | ||
| require.NoError(t, err) | ||
| // + 6 because there are two keyspace entries each of which has three metrics | ||
| assert.Equal(t, len(getDefaultRedisMetrics())+6, md.DataPointCount()) | ||
| rm := md.ResourceMetrics().At(0) | ||
| value, _ := rm.Resource().Attributes().Get("redis.instance") |
There was a problem hiding this comment.
Please add this convention to the specs. Also why not using "service.name=redis" and "service.instance=3"?
There was a problem hiding this comment.
As redis.instance is attribute specific to redis receiver so we do not need to add it to convention.
There was a problem hiding this comment.
That is not true :) conventions are even for a specific product/database if they are intended to be transferred on the wire for example between this collector and a backend (splunk for example). It is still a convention, and without having that in the specs it looks like a vendor specific convention.
manang-splunk
force-pushed
the
main
branch
2 times, most recently
from
f0a742f to
a4c36f1
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
manang-splunk
force-pushed
the
main
branch
2 times, most recently
from
d994568 to
5ff4d01
Compare
…te to all metrics
Co-authored-by: Ryan Fitzpatrick <[email protected]>
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Signed-off-by: Bogdan <[email protected]> Signed-off-by: Bogdan <[email protected]>
Description: Added new redis.instance resource attribute and also added config parameter redis_instance to make it configurable.
Testing: Updated the existing test case to verify redis.instance attribute.
Documentation: Added new config parameter in readme.md file.