fix: remove squash on configtls.TLSClientSetting for observiqexporter #5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
approved these changes
Oct 1, 2021
|
@djaglowski please have a look and please also submit a separate PR to add the right observIQ folks as codeowners for observiqexporter. |
tigrannajaryan
approved these changes
Oct 1, 2021
|
@tigrannajaryan, will do. @BinaryFissionGames Will you give this a look over? Also, please apply for membership so you can be a code owner. I will sponsor. |
|
Please rebase |
|
We should also update the README, since it references those squashed values; Otherwise this should be good! |
added 2 commits
October 1, 2021 20:40
…ontrib into remove_squash_configtls_observiq
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes squash on
configtls.TLSClientSettingand update corresponding yaml file for observiqexporter.See history here
Link to tracking Issue:
#5433