exporter/prometheusremotewrite: glue up and use Write-Ahead-Log #4874
Conversation
|
Kindly cc-ing @Aneurysm9 @alolita @tigrannajaryan after reviewing the PR that had been approved in the collector but wasn't merged in time before the move. |
|
@odeke-em can you please run go mod tidy for the prometheus remote write exporter. That should fix these failing tests. |
odeke-em
force-pushed
the
exporter-prometheusremotewrite-hookup-WAL
branch
6 times, most recently
from
2989f2d to
fd93cd3
Compare
odeke-em
force-pushed
the
exporter-prometheusremotewrite-hookup-WAL
branch
5 times, most recently
from
3d32d9f to
874674b
Compare
This change completes the WAL capability for the Prometheus Remote-Write exporter that allows recovery of data if the prior write requests weren't yet exported. This wires up a Write-Ahead-Log (WAL) that was implemented in PR open-telemetry/opentelemetry-collector#3597, which was split off from PR open-telemetry/opentelemetry-collector#3017. Note: there is very rare condition for which we can perhaps send the same data a couple of times, and it can happen if we haven't yet truncated the WAL, the RemoteWrite endpoint received the prior data but the process received a Ctrl+C, kill signal. However, this will be very rare and would have to be timed so fast and precisely. Replaces PR open-telemetry/opentelemetry-collector#3017 Updates PR open-telemetry/opentelemetry-collector#3597 Fixes #4751 Fixes open-telemetry/prometheus-interoperability-spec#9
odeke-em
force-pushed
the
exporter-prometheusremotewrite-hookup-WAL
branch
from
874674b to
8b5d368
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This change completes the WAL capability for the Prometheus Remote-Write exporter
that allows recovery of data if the prior write requests weren't yet exported.
This wires up a Write-Ahead-Log (WAL) that was implemented in
PR open-telemetry/opentelemetry-collector#3597, which
was split off from PR open-telemetry/opentelemetry-collector#3017.
Note: there is very rare condition for which we can perhaps send the
same data a couple of times, and it can happen if we haven't yet truncated
the WAL, the RemoteWrite endpoint received the prior data but the process
received a Ctrl+C, kill signal. However, this will be very rare and
would have to be timed so fast and precisely.
Replaces PR open-telemetry/opentelemetry-collector#3017
Updates PR open-telemetry/opentelemetry-collector#3597
Fixes #4751
Fixes open-telemetry/prometheus-interoperability-spec#9