Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate hostmetricsreceiver from Collector core to Collector contrib #4660

Closed
wants to merge 2,623 commits into from
Closed

Migrate hostmetricsreceiver from Collector core to Collector contrib #4660

wants to merge 2,623 commits into from

Conversation

alexperez52
Copy link
Contributor

This PR migrates the hostmetricsreceiver component from the Collector core repository to the Collector contrib repository.

This PR retains the commit history from core and includes plumbing fixes for go.mod, makefile, components.go.

Related issues include:
opentelemetry-collector/#3474
opentelemetry-collector/#3638

jrcamp and others added 30 commits June 10, 2021 02:29
@jrcamp
Convert zipkinv2 to to/from translator interfaces (#3409)
fd38d74 
* Convert zipkinv2 to to/from translator interfaces

Doesn't yet have encode/decoders.

* move v2 test files to zipkinv2
@rakyll
Adjust default retry settings for the PRW Exporter (#3416)
56a929a 
The default retry settings are far off from the Prometheus
Server's behavior. Retry more aggressively to avoid excessive
in-memory buffering.

Also fixes open-telemetry/prometheus-interoperability-spec#54 because the test
times out before the retry is sent.
@bogdandrutu
Update FileDataProvider to use the new model.Unmarshaler, avoid Inter…
23f70e2 
…nalRep usage (#3398)

Signed-off-by: Bogdan Drutu <[email protected]>
@mapno
Use cmd's context instead of background (#3418)
b62c50a
@bogdandrutu
Add tests for OTLP JSON encode/decode (#3400)
0d74747 
Signed-off-by: Bogdan Drutu <[email protected]>
@jrcamp
zipkinv1: move to translator and encoders interfaces (#3419)
2569435 
* zipkinv1: move to translator and encoders interfaces

* review feedback
@bogdandrutu
Remove unnecessary proto marshaler tests, avoid using InternalRep in …
3050c8e 
…otlprecv (#3386)

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Use the new marshaler/unmarshaler in Kafka receiver (#3402)
49a5753 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Avoid compiling in parallel same time without that (#3382)
0e5784c 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Remove test only code, avoid unsing proto and InternalRep in testdata (…
27df57b 
…#3387)

Signed-off-by: Bogdan Drutu <[email protected]>
@rmfitzpatrick
Replace Viper with Koanf to add map case sensitivity (#3337)
e035ad1
@dependabot
Bump go.uber.org/atomic from 1.7.0 to 1.8.0 (#3429)
703bbb4 
Bumps [go.uber.org/atomic](https://github.com/uber-go/atomic) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/uber-go/atomic/releases)
- [Changelog](https://github.com/uber-go/atomic/blob/master/CHANGELOG.md)
- [Commits](uber-go/atomic@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: go.uber.org/atomic
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bogdandrutu
Remove usage of grpc-gateway in otlpreceiver. Http protocols are diff…
cda019f 
…erent than grpc (#3422)

Signed-off-by: Bogdan Drutu <[email protected]>
@dependabot
Bump github.com/prometheus/client_golang from 1.10.0 to 1.11.0 (#3428)
afbdd8b 
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.10.0 to 1.11.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.10.0...v1.11.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bogdandrutu
Change oltpreceiver to use the new pdatagrpc, avoid proto dependency (#…
cd9eeaf 
…3406)

Signed-off-by: Bogdan Drutu <[email protected]>
@eddyleelin @tigrannajaryan
Edit type/func documentation in the consumer package (#3269)
1fada74 
* Edited grammar of pdata doc.go

* Added missing word

* Fixed typos in pdata/common.go

* Added missing String method docs

This fix makes the pdata folder consistent in documenting the String methods.

* Fixed spacing in doc example

* Fixed spacing issues in multiple examples

This issue was causing many example snippets to show up incorrectly on the godoc

* Fixed spacing issue on Range example

* Fixed spacing in At example

* Fixed more spacing errors in examples

* Fixed error in ResourceMetrics header describing InstrumentationLibraryMetrics

* Fixed another header referencing wrong method

* Added documentation for pdata.Resource

* Updated outdated links to Span OTLP definition

* Cleaned up wording in SpanStatus doc

* Fixed more spacing errors in examples

* Fixed typos in type docs

* Cleaned up formatting in consumererror

* Cleaned up consumerhelper doc typos

* Updated docs in consumertest

- Fixed wrong description of NewErr
- Added doc for Capabilities method

* Update CHANGELOG.md

* Fixed formatting errors in cmd/pdatagen

Changing here will ensure that the changes to consumer/pdata/generated_* files will persist after running `go run cmd/pdatagen/main.go`.

* Removed unused imports

* Update CHANGELOG.md

* Fixed generated code lint failures

* Revert changes in pdatagen and pdata/generated

* Update NewErr docstring

For func defined in consumer/consumertest/err.go

Co-authored-by: Tigran Najaryan <[email protected]>

* Updated docstring for TraceState

Renamed "message" to "string"

Co-authored-by: Tigran Najaryan <[email protected]>
@bogdandrutu
Remove usage of internal proto in configgrpc tests (#3435)
e8fbda8 
Updates #3104

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Use the new Marshaler in the OTLP HTTP exporter (#3433)
2bc0b19 
Updates #3104

Signed-off-by: Bogdan Drutu [email protected]
@bogdandrutu
Remove unnecessary public structs from testbed (#3432)
531fd92 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Move zipkin constants to an internal package (#3431)
fc413fc 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Add grpc response struct for all signals instead of returning interfa…
d5a1e43 
…ce (#3437)

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Fix build due to a race condition in merging PRs (#3440)
fc6ba8e 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Add comments to translation interfaces, clarify on error return value…
4c503dd 
… cannot be used (#3421)

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Remove usage of ToOtlpProtoBytes, will be removed after Marshaler is …
92d3c6f 
…released (#3434)

Signed-off-by: Bogdan Drutu <[email protected]>
@jrcamp @bogdandrutu
zipkinv2: add encoders, decoders, marshalers (#3426)
e10e703 
* zipkinv2: add encoders, decoders, marshalers

Also update zipkin receiver to use them.

* don't check returned value on error

* review feedback

Co-authored-by: Bogdan Drutu <[email protected]>
@rakyll
Return concrete error type (#3360)
f763d8b 
Go development practices favors returning concrete types over interfaces, so the users don't have to force cast the return value to the concrete type and the APIs self document the returned error type.
@bogdandrutu
Small cleanups in testbed (#3445)
a1bd429 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Remove unnecessary exclude rules from golangci (#3441)
0d94201 
Signed-off-by: Bogdan Drutu <[email protected]>
@dashpole
Disallow renaming metrics using the prometheus receiver (#3410)
05f16c5 
* disallow renaming metrics using the prometheus receiver

* add TODO for removing the validation
@mxiamxia
move cgroup and iruntime utils from memory_limiter to internal foler (#…
b06ffe5 
…3448)
bogdandrutu and others added 19 commits August 9, 2021 08:31
@bogdandrutu
Small nit in collector implementation (#3796)
441e9ff 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Remove unnecessary private function in obsreport (#3790)
08a3dff 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Change obsreport exporter to accept ExporterCreateSettings (#3789)
bb9569f 
Signed-off-by: Bogdan Drutu <[email protected]>
@dependabot @jpkrohling
Bump github.com/jaegertracing/jaeger from 1.24.0 to 1.25.0 (#3802)
28acc7d 
* Bump github.com/jaegertracing/jaeger from 1.24.0 to 1.25.0

Bumps [github.com/jaegertracing/jaeger](https://github.com/jaegertracing/jaeger) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/jaegertracing/jaeger/releases)
- [Changelog](https://github.com/jaegertracing/jaeger/blob/master/CHANGELOG.md)
- [Commits](jaegertracing/jaeger@v1.24.0...v1.25.0)

---
updated-dependencies:
- dependency-name: github.com/jaegertracing/jaeger
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add logger parameter to Jaeger Agent HTTP server

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juraci Paixão Kröhling <[email protected]>
@dependabot
Bump google.golang.org/grpc from 1.39.0 to 1.39.1 (#3803)
2d3bd18 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.0 to 1.39.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.39.0...v1.39.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/go-playground/validator/v10 in /cmd/mdatagen (#3801)
9184f1e 
Bumps [github.com/go-playground/validator/v10](https://github.com/go-playground/validator) from 10.8.0 to 10.9.0.
- [Release notes](https://github.com/go-playground/validator/releases)
- [Commits](go-playground/validator@v10.8.0...v10.9.0)

---
updated-dependencies:
- dependency-name: github.com/go-playground/validator/v10
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bogdandrutu
Remove duplicate code in zipkinv2 marshaler (#3784)
a00190f 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Mark issues as stale after 2y and close in 1m (#3806)
5c8887c 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Fix small bug in jaeger translation, could generate empty proto spans (…
955f96e 
…#3808)

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Bump go.uber.org/zap from v1.18.1 to v1.19.0 (#3810)
8038673 
Signed-off-by: Bogdan Drutu <[email protected]>
@jchengsfx
Release v0.32.0 (#3813)
f2b5a3a
@bogdandrutu
Small nit in setflag ParserProvider (#3807)
a360414 
This PR cuts out a few steps, including copying the map, calling IntfaceKeysToStrings, and merging the map with an empty map.

Signed-off-by: Bogdan Drutu <[email protected]>
update oc internal, prometheus exporters to use attributes (#3770)
632ed32 
* update oc internal, prometheus exporters to use attributes

* rename addAttributesToDoubleHistogramDataPoints

* cleaned up TODOs, mentioned the code in the issue instead
move AttributeValueToString and AttributeMapToMap to pdata (#3820)
7f8f321 
Moving AttributeValueToString and AttributeMapToMap from `tracetranslator` to `pdata` for common use across signals. The original functions were left as wrappers to their `pdata` counterparts and marked as deprecated.

**Link to tracking Issue:** First part of open-telemetry/opentelemetry-collector#3815

**Testing:** Moved existing tests to common_test
receiver/hostmetrics: update labels to attributes (#3811)
ffda9d5 
Updating `LabelsMap` to `Attributes` for hostmetrics receiver.

**Link to tracking Issue:** Part of #3535
@alexperez52
Delete irrelevant files
83d5763
@alexperez52
Add Makefile and go.mod
87ec247
@alexperez52
components.go fixup
13c1c0f
@alexperez52
added factory fixup
9c4e597
@alexperez52 alexperez52 requested review from a team and mx-psi August 16, 2021 20:03
@alolita alolita added release:required-for-ga Must be resolved before GA release spec:trace labels Aug 16, 2021
@alolita
Copy link
Member

alolita commented Aug 16, 2021

Hi @bogdandrutu @tigrannajaryan based on our discussion last week, we're starting to file PRs to move each core component to contrib. Please review and merge. Thanks!

mx-psi
mx-psi requested changes Aug 17, 2021
View reviewed changes
cmd/otelcontribcol/components.go
@@ -68,6 +68,7 @@ import (
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/dotnetdiagnosticsreceiver"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/filelogreceiver"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/fluentforwardreceiver"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/hostmetricsreceiver"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a replace directive on the main go.mod file for this to work

receiver/hostmetricsreceiver/codegen.go

// +build !windows

//go:generate mdatagen metadata.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have the mdatagen tool on this repository, we will need to move it here first.

receiver/hostmetricsreceiver/config_test.go
"go.opentelemetry.io/collector/component/componenttest"
"go.opentelemetry.io/collector/config"
"go.opentelemetry.io/collector/config/configtest"
"go.opentelemetry.io/collector/internal/processor/filterset"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an internal package from a different repository, so we need to move this over here first or find an alternative solution.

@alexperez52 alexperez52 marked this pull request as draft August 17, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi requested changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax will be requested when the pull request is marked ready for review dmitryax is a code owner

Assignees

@owais owais

Labels
release:required-for-ga Must be resolved before GA release spec:trace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.