Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/tanzuobservability] Support queued retries #4456

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

oppegard
Copy link
Member

@oppegard oppegard commented Aug 5, 2021

Description:
Added support for the retry_on_failure and sending_queue exporter helpers.

Testing:
Unit tests passed, and manually tested new config options for our exporter in failure scenarios.

Documentation:
Updated our README with the new config options

- Flush data once at end of pushTraceData/ConsumeTracesFunc instead of per-span

Signed-off-by: Peter Stone <[email protected]>
@oppegard oppegard requested review from a team and Aneurysm9 August 5, 2021 22:29
@bogdandrutu
Copy link
Member

Please review @thepeterstone

Copy link
Contributor

@thepeterstone thepeterstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tigrannajaryan
Copy link
Member

Closed/reopened to trigger CI that was stuck.

@oppegard
Copy link
Member Author

@tigrannajaryan or other maintainers: anything I can do to move this along?

@bogdandrutu bogdandrutu merged commit 1f36739 into open-telemetry:main Aug 25, 2021
@oppegard oppegard deleted the tobs-queued-retries branch August 26, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants