Rename feature of the metrics transform processor (metrics and labels) #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 83.92% 84.02% +0.09%
==========================================
Files 178 180 +2
Lines 9520 9594 +74
==========================================
+ Hits 7990 8061 +71
- Misses 1202 1204 +2
- Partials 328 329 +1
Continue to review full report at Codecov.
|
james-bebbington
approved these changes
Jul 2, 2020
processor/metricstransformprocessor/metrics_transform_processor.go
Outdated
Show resolved
Hide resolved
processor/metricstransformprocessor/metrics_transform_processor.go
Outdated
Show resolved
Hide resolved
processor/metricstransformprocessor/metrics_transform_processor.go
Outdated
Show resolved
Hide resolved
merge components.go
merge go.mod go.sum
…oogle/opentelemetry-collector-contrib into rename-metrics-label pull after amend commit
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
#376) * metric processor rename metrics and labels new branch * remove branches * removed validations * lint: remove unused variables related to validation * updated errors and error testing, optimized code based on comments * add metrics transform component into components file * have this built with the main collector * metric processor rename metrics and labels new branch * remove branches * removed validations * lint: remove unused variables related to validation * updated errors and error testing, optimized code based on comments * add metrics transform component into components file merge components.go * have this built with the main collector merge go.mod go.sum * go.mod resolved bad merge * go.mod resolved bad merge * go.sum after testing
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
* Refactor config: pipelines now under service This change moves 'pipelines' sections from the top level to under the 'service' section. * Fix typo in old comment
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
* Refactor syslog_input into a single operator The syslog_input operator was previously implemented as a builder that built two operators. While this is a perfectly fine solution, it happens to be the only place in this codebase where multiple operators are returned from a builder, excepting plugins. This new implementation builds the same two operators, but then wraps them together within a single operator. This will allow for the eventual simplification of other code, once plugins are also removed from this codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Rename Functionality including renaming the metrics name and the labels
Link to tracking Issue: #332
Testing: 100% coverage within module
Documentation: Detailed comments in code describing the responsibility of each function with a module level README
(This PR is to replace PR #347 because of incorrect and messy commits)