Add SignalFx demo configuration #371
Conversation
flands
commented
Jun 27, 2020
flands
commented
- collector.yaml
- k8s.yaml
* collector.yaml * k8s.yaml
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 171 171
Lines 9261 9261
=======================================
Hits 7732 7732
Misses 1199 1199
Partials 330 330
Continue to review full report at Codecov.
|
| # https://github.com/signalfx/signalfx-istio-adapter | ||
| zipkin: | ||
| processors: | ||
| batch: |
There was a problem hiding this comment.
Should we add blank line after each component? Would help visually associate comments with components.
There was a problem hiding this comment.
hum is the lack of black lines so this can be pasted directly into the k8s config?
|
Based on guidance from TC vendor-specific examples should be placed in vendor-specific exporter/receiver directories (see e.g. splunkhexexporter). |
| #- key: environment | ||
| #value: "YOUR_ENVIRONMENT_NAME" | ||
| #action: insert | ||
| queued_retry: |
There was a problem hiding this comment.
It will be more readable if this one is together with batch at top
| # https://github.com/signalfx/signalfx-istio-adapter | ||
| zipkin: | ||
| processors: | ||
| batch: |
There was a problem hiding this comment.
hum is the lack of black lines so this can be pasted directly into the k8s config?
Co-authored-by: Paulo Janotti <[email protected]>
Co-authored-by: Paulo Janotti <[email protected]>
* Add SignalFx demo configuration * collector.yaml * k8s.yaml * Update signalfx-k8s.yaml * Enable Zipkin for Istio Mixer Adapter * Update examples/signalfx/signalfx-collector.yaml Co-authored-by: Paulo Janotti <[email protected]> * Update examples/signalfx/signalfx-k8s.yaml Co-authored-by: Paulo Janotti <[email protected]> * Move to exporter directory Co-authored-by: Paulo Janotti <[email protected]>
…llector (#371) This is part of renaming task: open-telemetry/opentelemetry-collector#352
