-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [receiver/hostmetrics] Fix integration tests #36847
chore: [receiver/hostmetrics] Fix integration tests #36847
Conversation
Skip changelog? |
Triage: Adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
- key: process.owner | ||
value: | ||
stringValue: atoulme | ||
stringValue: neck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're ignoring these attributes now anyway maybe these can be removed? Or does the integration test framework expect them in some way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, the test framework actually removes them, so let's remove them as well 3b5936a
Description
Config.Unmarshal()
method is not called during this initialization. Fixed by using scraper's config interface:testdata/e2e/proc/1
required files were missing (statm, exe, cgroup, status).Link to tracking issue
Fixes #32536
Testing
Documentation