Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/sqlqueryreceiver] Add instrumentation scope to sqlqueryreceiver metrics & logs #36812

Merged

Conversation

dehaansa
Copy link
Contributor

Description

Add instrumentation scope to the metrics and logs emitted by the sqlqueryreceiver.

Link to tracking issue

Fixes #31028

Testing

Updated integration tests.

@dehaansa dehaansa requested review from dmitryax, crobert-1 and a team as code owners December 12, 2024 19:54
@dehaansa dehaansa changed the title feat: Add instrumentation scope to sqlqueryreceiver [receiver/sqlqueryreceiver] Add instrumentation scope to sqlqueryreceiver metrics & logs Dec 12, 2024
…nsa/opentelemetry-collector-contrib into feat/add-scope-to-sqlqueryreceiver
@dmitryax dmitryax merged commit 017b3d4 into open-telemetry:main Dec 18, 2024
160 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 18, 2024
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

//go:build integration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks Windows CIs, see #36917

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I didn't intend to commit that in this PR that was just for local tests. #36923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrumentation scope not present in Metric stream
5 participants