-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/sqlqueryreceiver] Add instrumentation scope to sqlqueryreceiver metrics & logs #36812
Merged
dmitryax
merged 7 commits into
open-telemetry:main
from
dehaansa:feat/add-scope-to-sqlqueryreceiver
Dec 18, 2024
Merged
[receiver/sqlqueryreceiver] Add instrumentation scope to sqlqueryreceiver metrics & logs #36812
dmitryax
merged 7 commits into
open-telemetry:main
from
dehaansa:feat/add-scope-to-sqlqueryreceiver
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehaansa
requested review from
dmitryax,
crobert-1 and
a team
as code owners
December 12, 2024 19:54
dehaansa
changed the title
feat: Add instrumentation scope to sqlqueryreceiver
[receiver/sqlqueryreceiver] Add instrumentation scope to sqlqueryreceiver metrics & logs
Dec 12, 2024
…nsa/opentelemetry-collector-contrib into feat/add-scope-to-sqlqueryreceiver
atoulme
approved these changes
Dec 13, 2024
dmitryax
approved these changes
Dec 18, 2024
songy23
reviewed
Dec 20, 2024
@@ -1,8 +1,6 @@ | |||
// Copyright The OpenTelemetry Authors | |||
// SPDX-License-Identifier: Apache-2.0 | |||
|
|||
//go:build integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks Windows CIs, see #36917
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I didn't intend to commit that in this PR that was just for local tests. #36923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add instrumentation scope to the metrics and logs emitted by the sqlqueryreceiver.
Link to tracking issue
Fixes #31028
Testing
Updated integration tests.