Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][testbed]: add options for retry/storage for filelog #36781

Merged
merged 5 commits into from
Dec 16, 2024
Merged

[chore][testbed]: add options for retry/storage for filelog #36781

merged 5 commits into from
Dec 16, 2024

Conversation

VihasMakwana
Copy link
Contributor

This options can be useful for test cases with retry/storage options enabled.

@VihasMakwana VihasMakwana requested a review from a team as a code owner December 11, 2024 10:03
@VihasMakwana VihasMakwana mentioned this pull request Dec 11, 2024
Open
ChrsMark
ChrsMark reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since these methods are exported I think we'd need a changelog.

@VihasMakwana VihasMakwana requested a review from a team December 11, 2024 13:37
@VihasMakwana
Copy link
Contributor Author

LGTM. Since these methods are exported I think we'd need a changelog.

@ChrsMark done! Can you take a look?

ChrsMark
ChrsMark approved these changes Dec 11, 2024
View reviewed changes
testbed/datasenders/stanza.go Show resolved Hide resolved
@VihasMakwana
Copy link
Contributor Author

@open-telemetry/cpp-contrib-approvers can we merge this?

@andrzej-stencel andrzej-stencel merged commit 8a2fb2d into open-telemetry:main Dec 16, 2024
160 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 16, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@VihasMakwana @sbylica-splunk
[chore][testbed]: add options for retry/storage for filelog (open-tel…
416d665 
…emetry#36781)

This options can be useful for test cases with retry/storage options
enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@atoulme atoulme atoulme approved these changes

Assignees

@TylerHelmuth TylerHelmuth

Labels
testbed
Projects
None yet
Milestone
v0.116.0
Development

Successfully merging this pull request may close these issues.
5 participants
@VihasMakwana @atoulme @ChrsMark @TylerHelmuth @andrzej-stencel