datadogexporter: read response body on pushSketches #36779
Merged
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
jade-guiton-dd,
liustanley and
mackjmr
songy23
reviewed
Dec 11, 2024
please fix |
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…6779) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The pushSketches function in the datadogexporter does not read the contents of the HTTP response's Body on return. The Go documentation states that the full response body from the http request should be read and closed to ensure that connections can be properly re-used: https://pkg.go.dev/net/http#Client.Do We saw this manifest as a high load of incoming metric traffic through the exporter creating a connection per request and essentially killing platform infrastructure (proxy, DNS) as a result. <!--Describe what testing was performed and which tests were added.--> #### Testing No additional testing added. Fix is running to great effect in private internal fork at extremely high scale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pushSketches function in the datadogexporter does not read the contents of the HTTP response's Body on return.
The Go documentation states that the full response body from the http request should be read and closed to ensure that connections can be properly re-used: https://pkg.go.dev/net/http#Client.Do
We saw this manifest as a high load of incoming metric traffic through the exporter creating a connection per request and essentially killing platform infrastructure (proxy, DNS) as a result.
Testing
No additional testing added. Fix is running to great effect in private internal fork at extremely high scale.