[extension/sumologic] Skip zombie processes on Windows #36772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
added
Run Windows
pjanotti
changed the title
|
One possibility that I didn't investigate is if these zombie processes are being created by the test itself. That can happen if the test somehow opens a handle to the process and the process ends, but the handle was not closed yet. |
mx-psi
approved these changes
Dec 11, 2024
codeboten
reviewed
Dec 11, 2024
There was a problem hiding this comment.
this looks ok to me, pinging code owners @rnishtala-sumo @chan-tim-sumo for review
rnishtala-sumo
approved these changes
Dec 16, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…y#36772) #### Description On Windows it consistently fails to get the name of certain processes, likely zombie process, reporting: "A device attached to the system is not functioning." My long term recommendation will be for the owners to directly use the Win32 API to get process information instead of the library: while it uses the correct permissions to get the process name it is not using the flag that allows to get the device name path which should avoid this issue even for zombie processes, I'm not sure if that is desirable or not. #### Link to tracking issue Fixes open-telemetry#36481 #### Testing Repro the failure locally and checked that the test passed locally with the change. I couldn't lint it locally on Windows (tool crash, will use CI to check that) #### Documentation Added changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Windows it consistently fails to get the name of certain processes, likely zombie process, reporting: "A device attached to the system is not functioning."
My long term recommendation will be for the owners to directly use the Win32 API to get process information instead of the library: while it uses the correct permissions to get the process name it is not using the flag that allows to get the device name path which should avoid this issue even for zombie processes, I'm not sure if that is desirable or not.
Link to tracking issue
Fixes #36481
Testing
Repro the failure locally and checked that the test passed locally with the change.
I couldn't lint it locally on Windows (tool crash, will use CI to check that)
Documentation
Added changelog