Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[awsxrayexporter] Generate url section in xray segment when net.peer.name is available #36530

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[awsxrayexporter] Generate url section in xray segment when net.peer.name is available #36530

merged 1 commit into from
Dec 5, 2024

Conversation

bjrara
Copy link
Contributor

@bjrara bjrara commented Nov 26, 2024

Description

Generate url section in X-Ray segment when net.peer.name is available

Link to tracking issue

Fixes #35375.

Testing

Unit test

@bjrara bjrara requested a review from a team as a code owner November 26, 2024 00:00
@bjrara bjrara requested a review from fatsheep9146 November 26, 2024 00:00
@github-actions github-actions bot requested review from srprash and wangzlei November 26, 2024 00:01
@bjrara bjrara changed the title Generate url section in xray segment when net.peer.name is available [xrayexporter] Generate url section in xray segment when net.peer.name is available Nov 27, 2024
@bjrara bjrara changed the title [xrayexporter] Generate url section in xray segment when net.peer.name is available [awsxrayexporter] Generate url section in xray segment when net.peer.name is available Nov 27, 2024
wangzlei
wangzlei approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@wangzlei wangzlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bjrara bjrara mentioned this pull request Dec 2, 2024
Merged
@TylerHelmuth TylerHelmuth merged commit 3fdb51b into open-telemetry:main Dec 5, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 5, 2024
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
@bjrara @ZenoCC-Peng
[awsxrayexporter] Generate url section in xray segment when net.peer.…
dbc9ee2 
…name is available (open-telemetry#36530)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Generate url section in X-Ray segment when net.peer.name is available

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
open-telemetry#35375.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangzlei wangzlei wangzlei approved these changes

@srprash srprash srprash approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@TylerHelmuth TylerHelmuth

Labels
exporter/awsxray
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.

Missing url from X-Ray segment
4 participants
@bjrara @TylerHelmuth @srprash @wangzlei