fix(compression): Changes that follow core breaking changes to the confighttp API #36399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnishtala-sumo
requested review from
a team,
mx-psi,
songy23,
atoulme and
dmitryax
as code owners
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
liustanley and
mackjmr
rnishtala-sumo
force-pushed
the
fix-contrib-tests
branch
3 times, most recently
from
a05ae7b to
8770113
Compare
rnishtala-sumo
commented
Nov 19, 2024
exporter/splunkhecexporter/go.mod
Outdated
| @@ -135,3 +135,7 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil | |||
| replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatatest => ../../pkg/pdatatest | |||
|
|
|||
| replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/golden => ../../pkg/golden | |||
|
|
|||
| replace go.opentelemetry.io/collector/config/configcompression => github.com/rnishtala-sumo/opentelemetry-collector/config/configcompression v0.0.0-20241118202008-518d136b719c | |||
There was a problem hiding this comment.
@dmitryax - as requested, I am using core changes from my fork in contrib temporarily.
There was a problem hiding this comment.
it isn't clear why I still get these errors, don't see them on my local.
../../exporter/splunkhecexporter/client.go:660:54: undefined: configcompression.TypeWithLevel
…st commit on branch (configure-compression-levels)
rnishtala-sumo
force-pushed
the
fix-contrib-tests
branch
from
8770113 to
5aa495e
Compare
atoulme
reviewed
Dec 7, 2024
| @@ -137,3 +137,7 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil | |||
| replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatatest => ../../pkg/pdatatest | |||
|
|
|||
| replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/golden => ../../pkg/golden | |||
|
|
|||
| replace go.opentelemetry.io/collector/config/configcompression => github.com/rnishtala-sumo/opentelemetry-collector/config/configcompression v0.0.0-20241204155200-78d83fd4ebca | |||
There was a problem hiding this comment.
I would rather we merge the changes in core and use the latest main snapshot.
There was a problem hiding this comment.
Closing this PR after SIG meeting discussion in favor of - open-telemetry/opentelemetry-collector#11805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes that follow core breaking changes to the confighttp API
Link to tracking issue
Issue - open-telemetry/opentelemetry-collector#10467