[chore] remove converter type from stanza #36288
Conversation
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
…into chore/converter-type-removal
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
| @@ -167,15 +173,6 @@ func (rt *rotationTest) Run(t *testing.T) { | |||
| fileName := filepath.Join(tempDir, "test.log") | |||
| backupFileName := filepath.Join(tempDir, "test-backup.log") | |||
|
|
|||
| // Build expected outputs | |||
There was a problem hiding this comment.
the generated entries for the expected log entries have not been used previously, as the require.Equal below has been commented out. I tried to make use of the plogtest.CompareLogs function to add the validation of the received log entries against the expected entries but ran into some troubles handling the order of the received log entries, which seems to be linked to the log entries being received in a random order during the log file rotation.
This however might be worth looking into as part of a separate PR dedicated to that.
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
|
Sorry for the delayed review. LGTM but now we need to resolve conflicts |
no worries, and thank you for the review - will look into resolving the conflicts today |
Signed-off-by: Florian Bacher <[email protected]>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR removes the `Converter` type that was previously used mainly by the stanza receiver adapter (see open-telemetry#35669 (comment) for more details). Two other receivers were still using the converter to generate test data within the unit tests, so those have been adapted as well with this PR <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Follow up to open-telemetry#35453 <!--Describe what testing was performed and which tests were added.--> #### Testing Adapted unit tests that were still using the converter --------- Signed-off-by: Florian Bacher <[email protected]>
Description
This PR removes the
Convertertype that was previously used mainly by the stanza receiver adapter (see #35669 (comment) for more details). Two other receivers were still using the converter to generate test data within the unit tests, so those have been adapted as well with this PRLink to tracking issue
Follow up to #35453
Testing
Adapted unit tests that were still using the converter