Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/pdatatest] support Profiles signal comparison #36273

Merged
merged 22 commits into from
Dec 10, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 8, 2024

Description

Link to tracking issue

Fixes #36232

@djaglowski
Copy link
Member

It would be great to have someone familiar with profiles review this too.

@odubajDT
Copy link
Contributor Author

It would be great to have someone familiar with profiles review this too.

I am still adding CompareOptions + unit tests to be sure everything is working as expected. But a pre-review would be very appreciated!

@odubajDT odubajDT force-pushed the profiles-pdata branch 3 times, most recently from 7bddcc2 to 4e32963 Compare November 14, 2024 07:51
@odubajDT odubajDT marked this pull request as ready for review November 14, 2024 07:52
@odubajDT odubajDT requested a review from a team as a code owner November 14, 2024 07:52
@odubajDT odubajDT force-pushed the profiles-pdata branch 2 times, most recently from f1bdacd to 217433a Compare November 26, 2024 12:40
@odubajDT odubajDT force-pushed the profiles-pdata branch 2 times, most recently from d6f972d to 58c2492 Compare December 4, 2024 13:31
@odubajDT
Copy link
Contributor Author

odubajDT commented Dec 6, 2024

@mx-psi could you have a look please ?

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. @dmathieu could you also take a look?

@mx-psi mx-psi requested a review from dmathieu December 10, 2024 11:33
@mx-psi
Copy link
Member

mx-psi commented Dec 10, 2024

@odubajDT can you fix the merge conflicts?

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@mx-psi mx-psi merged commit ccf3cae into open-telemetry:main Dec 10, 2024
159 of 160 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/pdatatest] Support profiles signal comparison
5 participants