[receiver/purefa] Pure Storage FlashArray - Purity v6.6.11+ Native OpenMetrics Support #36251
+100
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add tests. |
|
@atoulme Tests have been added. Thank you. |
jpkrohling
reviewed
Nov 18, 2024
chrroberts-pure
changed the title
jpkrohling
approved these changes
Nov 27, 2024
|
Hi @jpkrohling @atoulme I'm happy with this, and I've tested with a Pure FlashArray. Please let me know if there is anything else that is blocking the merge of this PR. Thank you. |
jpkrohling
approved these changes
Dec 10, 2024
jpkrohling
approved these changes
Dec 10, 2024
atoulme
approved these changes
Dec 10, 2024
atoulme
added
the
ready to merge
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…enMetrics Support (open-telemetry#36251) This PR implements the changes required to scrape metrics from arrays with newer Purity versions. In Pure Storage FlashArray Purity version 6.6.11, they released a feature that allows OpenMetrics to be scraped directly from the array without the use of an OpenMetrics Exporter. These changes include - Enabling support to disable TLS Insecure Skip Verify if required (default is to verify) - Enabling support for the `namespace` HTTP param that is supported by the Purity OpenMetrics exporter. #### Link to tracking issue None <!--Describe what testing was performed and which tests were added.--> #### Testing Tests have been updated for the scraper and default configs for the new Namespace and TLSInsecureSkipVerify configurations. I have tested this with a live FlashArray running 6.6.11 #### Documentation The Readme was updated to show a new example of a scrape using Purity version 6.6.11+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes required to scrape metrics from arrays with newer Purity versions.
In Pure Storage FlashArray Purity version 6.6.11, they released a feature that allows OpenMetrics to be scraped directly from the array without the use of an OpenMetrics Exporter.
These changes include
namespaceHTTP param that is supported by the Purity OpenMetrics exporter.Link to tracking issue
None
Testing
Tests have been updated for the scraper and default configs for the new Namespace and TLSInsecureSkipVerify configurations.
I have tested this with a live FlashArray running 6.6.11
Documentation
The Readme was updated to show a new example of a scrape using Purity version 6.6.11+.