Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Fix handling of slice values in flatten function by considering depth option #36198

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bacherfl
Copy link
Contributor

@bacherfl bacherfl commented Nov 5, 2024

Description

This PR adapts the flatten function to also consider the depth option when handling slice values. Before this change, the function flattened slice values beyond the given depth.

Link to tracking issue

Fixes #36161

Testing

Added unit and e2e tests

Documentation

No changes here, as the docs already mention the expected behavior of the function when the depth option is set

Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/ottl] unexpected behavior of flatten function when handling slice attributes at top level
2 participants