[extension/jsonlogencoding] Support marshaling multiple logs #36156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dao-jun,
dmitryax,
MovieStoreGuy and
VihasMakwana
MovieStoreGuy
approved these changes
Nov 11, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
VihasMakwana
approved these changes
Nov 26, 2024
|
@atoulme looks good to be merged once you resolve conflicts. |
dao-jun
approved these changes
Nov 27, 2024
atoulme
force-pushed
the
consume_multiple_records
branch
from
43183ef to
866879a
Compare
atoulme
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change how logs are marshaled. Instead of marshaling just the first log, marshal all logs into a JSON array.
Link to tracking issue
Fixes #34064