[processor/probabilisticsampler] Added Spans Count Metric #36151
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alok Kumar Singh <[email protected]>
github-actions
bot
added
the
processor/probabilisticsampler
atoulme
reviewed
Nov 3, 2024
atoulme
reviewed
Nov 3, 2024
| @@ -174,6 +174,7 @@ func (tp *traceProcessor) processTraces(ctx context.Context, td ptrace.Traces) ( | |||
| td.ResourceSpans().RemoveIf(func(rs ptrace.ResourceSpans) bool { | |||
| rs.ScopeSpans().RemoveIf(func(ils ptrace.ScopeSpans) bool { | |||
| ils.Spans().RemoveIf(func(s ptrace.Span) bool { | |||
| tp.telemetryBuilder.ProcessorProbabilisticSamplerCountSpansSampled.Add(ctx, 1) | |||
There was a problem hiding this comment.
I am not sure I get this - did you mean to record a count of all spans going through the processor?
There was a problem hiding this comment.
Yes. As I understand the issue linked this is what was requested.
Signed-off-by: Alok Kumar Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generated spans count metric using the
metadata.yamland incremented the counter with each span processing.Link to tracking issue
Fixes: #34272