[receiver/datadogreceiver] Fix /api/v1/check_run response to return JSON status: ok #36029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdgeisler
requested review from
jpkrohling,
MovieStoreGuy and
a team
as code owners
MovieStoreGuy
approved these changes
Oct 29, 2024
jpbarto
pushed a commit
to jpbarto/opentelemetry-collector-contrib
that referenced
this pull request
Oct 29, 2024
…SON status: ok (open-telemetry#36029) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Changing the `/api/v1/check_run` response for service checks to be on par with the datadog api spec as per https://docs.datadoghq.com/api/latest/service-checks/ This is the same implementation as the PR for the series endpoints open-telemetry#35744 <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36027 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests updated and are passing <!--Describe the documentation added.--> #### Documentation Changelog updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the
/api/v1/check_runresponse for service checks to be on par with the datadog api spec as per https://docs.datadoghq.com/api/latest/service-checks/This is the same implementation as the PR for the series endpoints #35744
Link to tracking issue
Fixes #36027
Testing
Unit tests updated and are passing
Documentation
Changelog updated