Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connector, exporter/datadog] Enable compute_stats_by_span_kind and peer_tags_aggregation by default #35969

Merged
merged 6 commits into from
Dec 10, 2024
Merged

[connector, exporter/datadog] Enable compute_stats_by_span_kind and peer_tags_aggregation by default #35969

merged 6 commits into from
Dec 10, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Oct 23, 2024

Description

Flip configs traces::compute_stats_by_span_kind, traces::peer_tags_aggregation and traces::peer_service_aggregation to true by default

@songy23 songy23 requested review from mx-psi and a team as code owners October 23, 2024 21:07
songy23
songy23 commented Oct 23, 2024
View reviewed changes
.chloggen/dd-conn-peer-tags.yaml Outdated Show resolved Hide resolved
.chloggen/dd-exp-peer-tags.yaml Outdated Show resolved Hide resolved
mx-psi
mx-psi approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to request review from any other team at Datadog? Do we need to wait to merge this by some particualr date?

@rickbatka
Copy link

Hi @mx-psi and @songy23 , yes we need to wait to merge this, likely a few weeks. How do you want to handle that? Is there a tag to block merging? Or I could be added as a required reviewer and I'll withhold my approval until we are ready?

@songy23 songy23 added on hold This is blocked by another PR/issue never stale Issues marked with this label will be never staled and automatically removed labels Oct 24, 2024
mx-psi
mx-psi previously requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge per the comment above

@rickbatka
Copy link

Hi @mx-psi and @songy23 , we are ready to merge this PR now!

@mx-psi mx-psi dismissed their stale review December 10, 2024 08:46

Dismissing block per comment above

@mx-psi mx-psi merged commit adef54e into open-telemetry:main Dec 10, 2024
160 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 10, 2024
@songy23 songy23 deleted the dd-peer-tags branch December 10, 2024 14:09
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@songy23 @mx-psi @sbylica-splunk
[connector, exporter/datadog] Enable compute_stats_by_span_kind and p…
736f96d 
…eer_tags_aggregation by default (open-telemetry#35969)

#### Description
Flip configs `traces::compute_stats_by_span_kind`,
`traces::peer_tags_aggregation` and `traces::peer_service_aggregation`
to true by default

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkalmakis pkalmakis pkalmakis approved these changes

@mx-psi mx-psi mx-psi approved these changes

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

@jade-guiton-dd jade-guiton-dd Awaiting requested review from jade-guiton-dd

Assignees

@jpkrohling jpkrohling

Labels
connector/datadog exporter/datadog Datadog components never stale Issues marked with this label will be never staled and automatically removed on hold This is blocked by another PR/issue pkg/datadog
Projects
None yet
Milestone
v0.116.0
Development

Successfully merging this pull request may close these issues.
5 participants
@songy23 @rickbatka @mx-psi @pkalmakis @jpkrohling