[chore] add receiver adapter benchmark tests #35833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
djaglowski
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Thanks for putting this together @bacherfl.
This looks good. The one thing we should consider is the content of the log. I think an empty log will bypass a lot of the conversion and batching logic, so we may need to find a more complex structure. The simplicity of the input operator itself is great though. The entry/entries should probably be pre-generated so that we're not measuring the work of creating them.
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
|
Thanks for the review @djaglowski! I have updated the PR now to generate a complex log entry which will be used by the input operator during the tests |
djaglowski
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a benchmark test for the receiver adapter which tests the performance of handling the log entries sent to the
LogEmitter, which are then received and converted by the receiver adapter. The changes have been made based on the comment linked here: #35669 (comment)Link to tracking issue
Part of #35453
Testing
Added additional benchmark tests