-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/elasticsearch] Preserve attribute names and metric names on prefix conflict in OTel mapping mode #35651
Merged
andrzej-stencel
merged 10 commits into
open-telemetry:main
from
carsonip:metric-name-conflict
Oct 17, 2024
Merged
[exporter/elasticsearch] Preserve attribute names and metric names on prefix conflict in OTel mapping mode #35651
andrzej-stencel
merged 10 commits into
open-telemetry:main
from
carsonip:metric-name-conflict
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
changed the title
[WIP][exporter/elasticsearch] Fix metric name conflict handling
[exporter/elasticsearch] Preserve attribute names and metric names on prefix conflict in OTel mapping mode
Oct 16, 2024
felixbarny
reviewed
Oct 16, 2024
felixbarny
approved these changes
Oct 16, 2024
lahsivjar
approved these changes
Oct 16, 2024
andrzej-stencel
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metric names should be flattened and exported as is, even when one metric name is a prefix of another. Same for attributes for all logs, metrics and traces.
Link to tracking issue
Testing
Documentation