-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/receiver_creator] Add support for enabling receivers/scrapers from K8s hints #35617
Conversation
790635e
to
d939e0b
Compare
18378d6
to
6d876f2
Compare
@dmitryax I have opened this for review, please feel free to take a look when you get the chance. Since #35544 was merged I could also add the Logs' part here if that's easier for you to review, however that would make the PR significantly bigger. Let me know what you prefer. Update Logs included-> https://github.com/open-telemetry/opentelemetry-collector-contrib/compare/main...ChrsMark:opentelemetry-collector-contrib:logs_hints?expand=1 |
5b8845d
to
7c65ab2
Compare
Thank's @dmitryax, I've removed the redundant config field. It should be good to go now. |
5029812
to
145ad1b
Compare
Thank's @dmitryax . Comments should be addressed now. PTAL. |
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Description
This PR implements the metrics' part suggested at #34427 (comment). The current implementation only supports hints coming from Pods (wip with Logs included-> https://github.com/open-telemetry/opentelemetry-collector-contrib/compare/main...ChrsMark:opentelemetry-collector-contrib:logs_hints?expand=1)This PR implements what it was decided at #34427 (comment).
See the README docs for the description of this feature: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/35617/files#diff-4127365c4062a7510fb7fede0fa239e9232549732898303d94c12fef0433d39d
TODOs:
Link to tracking issue
Part of #34427
Testing
Added unit-tests.
Documentation
Added
How to test this locally
More testing target Pods
busybox-multi-logs.txt
busybox-single-logs.txt
redis-nginx-mutli.txt
redis-single.txt
redis-single-logs.txt