[processor/metricsgeneration] Generate metrics even when the second metric's value is 0 #35537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etric's value is 0
github-actions
bot
added
the
processor/metricsgeneration
crobert-1
commented
Oct 1, 2024
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking |
There was a problem hiding this comment.
I consider this to be a breaking change as existing collector configurations will now potentially be emitting more metrics than before.
crobert-1
commented
Oct 1, 2024
processor/metricsgenerationprocessor/testdata/input_metric_types/config.yaml
Outdated
Show resolved
Hide resolved
crobert-1
commented
Oct 1, 2024
atoulme
approved these changes
Oct 2, 2024
dmitryax
reviewed
Oct 2, 2024
- Reorganize logic to make dropping empty metrics more straight-forward - Rename variable - Also renamed a method to a more accurate name as its functionality changed.
dmitryax
approved these changes
Oct 2, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…etric's value is 0 (open-telemetry#35537) **Description:** Originally, this processor would not generate a new metric if the value of the metric configured as `metric2` was `0`. There are valid reasons why this calculation should still be done, and a new metric should be calculated. **Link to tracking Issue:** Resolves open-telemetry#35533 **Testing:** Added tests for each calculation type to show expected results when the second metric's value is 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Originally, this processor would not generate a new metric if the value of the metric configured as
metric2was0. There are valid reasons why this calculation should still be done, and a new metric should be calculated.Link to tracking Issue:
Resolves #35533
Testing:
Added tests for each calculation type to show expected results when the second metric's value is 0.