Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetrics] Make HOST_PROC_MOUNTINFO part of envMap #35504

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 1, 2024

Description:
Make HOST_PROC_MOUNTINFO part of envMap instead of environment variable

@atoulme atoulme requested review from dmitryax and a team as code owners October 1, 2024 06:39
@atoulme atoulme force-pushed the use_HOST_PROC_MOUNTINFO branch from 58bcd5b to f3cdfce Compare October 1, 2024 06:39
@github-actions github-actions bot requested a review from braydonk October 1, 2024 06:40
@atoulme atoulme force-pushed the use_HOST_PROC_MOUNTINFO branch from f3cdfce to 8c3f37c Compare October 1, 2024 06:40
Copy link
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme atoulme force-pushed the use_HOST_PROC_MOUNTINFO branch from 8c3f37c to 7042a1b Compare October 2, 2024 04:35
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Oct 2, 2024
@atoulme atoulme force-pushed the use_HOST_PROC_MOUNTINFO branch from 7042a1b to 38b1383 Compare October 8, 2024 05:58
@atoulme atoulme force-pushed the use_HOST_PROC_MOUNTINFO branch from 38b1383 to b699129 Compare October 8, 2024 06:03
@MovieStoreGuy MovieStoreGuy merged commit f4a4206 into open-telemetry:main Oct 10, 2024
155 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 10, 2024
@atoulme atoulme deleted the use_HOST_PROC_MOUNTINFO branch October 25, 2024 16:04
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…telemetry#35504)

**Description:** 
Make HOST_PROC_MOUNTINFO part of envMap instead of environment variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants