[chore][pkg/ottl] Apply more standards to RemoveXML converter #35463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
TylerHelmuth
approved these changes
Sep 27, 2024
|
I also added handling for empty xml docs to the shared parsing function. |
TylerHelmuth
approved these changes
Sep 27, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…elemetry#35463) This PR just applies a couple more standards that I've been following with the other XML converters. Namely: - Create the function via the factory to ensure the constructor validation is applied - Use `xmlquery.QueryAll` instead of the deprecated `xmlquery.FindEach`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just applies a couple more standards that I've been following with the other XML converters. Namely:
xmlquery.QueryAllinstead of the deprecatedxmlquery.FindEach