[exporter/elasticsearch] Implement receiver-based routing under *_dynamic_index config #35417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
changed the title
felixbarny
approved these changes
Sep 25, 2024
lahsivjar
approved these changes
Sep 25, 2024
| @@ -121,21 +121,21 @@ This can be customised through the following settings: | |||
|
|
|||
| - `logs_dynamic_index` (optional): uses resource, scope, or log record attributes to dynamically construct index name. | |||
| - `enabled`(default=false): Enable/Disable dynamic index for log records. If `data_stream.dataset` or `data_stream.namespace` exist in attributes (precedence: log record attribute > scope attribute > resource attribute), they will be used to dynamically construct index name in the form `logs-${data_stream.dataset}-${data_stream.namespace}`. Otherwise, if | |||
| `elasticsearch.index.prefix` or `elasticsearch.index.suffix` exist in attributes (precedence: resource attribute > scope attribute > log record attribute), they will be used to dynamically construct index name in the form `${elasticsearch.index.prefix}${logs_index}${elasticsearch.index.suffix}`. Otherwise, the index name falls back to `logs-generic-default`, and `logs_index` config will be ignored. Except for prefix/suffix attribute presence, the resulting docs will contain the corresponding `data_stream.*` fields. | |||
| `elasticsearch.index.prefix` or `elasticsearch.index.suffix` exist in attributes (precedence: resource attribute > scope attribute > log record attribute), they will be used to dynamically construct index name in the form `${elasticsearch.index.prefix}${logs_index}${elasticsearch.index.suffix}`. Otherwise, if scope name matches regex `/receiver/(\w*receiver)`, `data_stream.dataset` will be capture group #1. Otherwise, the index name falls back to `logs-generic-default`, and `logs_index` config will be ignored. Except for prefix/suffix attribute presence, the resulting docs will contain the corresponding `data_stream.*` fields. | |||
There was a problem hiding this comment.
This will change the way data is routed for users who have enabled a (logs|metrics|traces)_dynamic_index property. Previously, e.g. metrics from the Host Metrics receiver were sent to metrics-generic-default. After this change, they will be sent to metrics-hostmetrics-default, correct? This could potentially break a user's setup, assuming they have e.g. some alerts set up querying for host metrics from the metrics-generic-default data stream?
Perhaps we should change the changelog entry's change_type from enhancement to breaking?
There was a problem hiding this comment.
Changed to breaking
carsonip
commented
Sep 26, 2024
andrzej-stencel
approved these changes
Sep 30, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…amic_index config (open-telemetry#35417) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Implement receiver-based routing under *_dynamic_index config. e.g. Set data_stream.dataset to hostmetricsreceiver (or hostmetricsreceiver.otel in the OTel output mode) for the scope name github.com/open-telemetry/opentelemetry-collector-contrib/receiver/hostmetricsreceiver/internal/scraper/cpuscraper **Link to tracking Issue:** <Issue number if applicable> Fixes open-telemetry#34246 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implement receiver-based routing under *_dynamic_index config.
e.g. Set data_stream.dataset to hostmetricsreceiver (or hostmetricsreceiver.otel in the OTel output mode) for the scope name github.com/open-telemetry/opentelemetry-collector-contrib/receiver/hostmetricsreceiver/internal/scraper/cpuscraper
Link to tracking Issue:
Fixes #34246
Testing:
Documentation: