[exporter/loadbalancing] Add return_hostnames option to k8s resolver #35411
Conversation
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@mx-psi @jpkrohling , please let me know if I have not completed a task to get this reviewed. I don't want to see it closed due to staleness. |
|
Hey, thanks for the PR. No worries about the PR being closed, we can reopen if needed. It may take some time for @jpkrohling to get back to this PR (as in, it may take a couple of additional weeks at least), in the mean time, you can try to make sure that CI passes by:
I am happy to help with both of those if anything is unclear. |
|
@mx-psi Can do, just wanted to make sure it wasn't going to get lost. I'll work on those two tasks soon. Thanks for getting back to me so fast. |
snuggie12
force-pushed
the
lbexporter-add-return-hostnames-opt-to-k8s-resolver
branch
from
0b8513d to
49cd9e4
Compare
snuggie12
force-pushed
the
lbexporter-add-return-hostnames-opt-to-k8s-resolver
branch
2 times, most recently
from
e0892f1 to
db3b7d4
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
snuggie12
force-pushed
the
lbexporter-add-return-hostnames-opt-to-k8s-resolver
branch
from
db3b7d4 to
991dee9
Compare
|
Unit tests still passing after the slice -> map change. I also updated the image in our test environment and restarted all of our tail samplers and everything still is functioning. |
|
There are some linting failures here: |
snuggie12
force-pushed
the
lbexporter-add-return-hostnames-opt-to-k8s-resolver
branch
from
991dee9 to
ca265dc
Compare
snuggie12
force-pushed
the
lbexporter-add-return-hostnames-opt-to-k8s-resolver
branch
from
ca265dc to
a5c48c0
Compare
snuggie12
deleted the
lbexporter-add-return-hostnames-opt-to-k8s-resolver
branch
…pen-telemetry#35411) **Description:** Adds an optional configuration option to the k8s resolver which allows for hostnames to be returned instead of IPs. This allows certain scenarios like using istio in sidecar mode. Requirements have been added to the documentation. **Link to tracking Issue:** open-telemetry#18412 **Testing:** Added corresponding hostname-based tests for adding backends/endpoints as well as deleting them. There were also tests missing for the k8s handler and so some tests were added as well there. Specifically failing if you want hostnames, but endpoints are returned that do not have hostnames. Aside from unit tests, also ran this in our lab cluster and deleted pods or performed rollouts to our statefulset. Somewhat tangential to the PR itself, but istio now reports mTLS traffic with zero workarounds required which was the motivation for the issue. **Documentation:** Added documentation explaining the new option and the requirements needed to use it. Also added an additional "important" note object specifically calling out that the k8s resolver needs RBAC to work.
Description: Adds an optional configuration option to the k8s resolver which allows for hostnames to be returned instead of IPs. This allows certain scenarios like using istio in sidecar mode. Requirements have been added to the documentation.
Link to tracking Issue: #18412
Testing: Added corresponding hostname-based tests for adding backends/endpoints as well as deleting them. There were also tests missing for the k8s handler and so some tests were added as well there. Specifically failing if you want hostnames, but endpoints are returned that do not have hostnames.
Aside from unit tests, also ran this in our lab cluster and deleted pods or performed rollouts to our statefulset.
Somewhat tangential to the PR itself, but istio now reports mTLS traffic with zero workarounds required which was the motivation for the issue.
Documentation: Added documentation explaining the new option and the requirements needed to use it. Also added an additional "important" note object specifically calling out that the k8s resolver needs RBAC to work.