[processor/deltatocumulative]: do not drop Gauge, Summary #35372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
added
the
release:blocker
jpkrohling
approved these changes
Sep 24, 2024
| require.NoError(t, err) | ||
|
|
||
| if diff := compare.Diff([]pmetric.Metrics{out}, sink.AllMetrics()); diff != "" { | ||
| t.Fatal(diff) |
There was a problem hiding this comment.
t.Fatal? Why not "assert.Fail()", as the other ones? Or assert.Len(t, "", compare.Diff(...)) ?
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…etry#35372) **Description:** As an oversight, open-telemetry#33286 not only started dropping metrics without datapoints, but also all Gauges and Summaries. This change correctly passes those types through unaltered. **Link to tracking Issue:** Fixes open-telemetry#35284 **Testing:** `TestIgnore` was added _before_ fixing. It fails on current main, passes after this change **Documentation:** not needed --------- Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As an oversight, #33286 not only started dropping metrics without datapoints, but also all Gauges and Summaries.
This change correctly passes those types through unaltered.
Link to tracking Issue: Fixes #35284
Testing:
TestIgnorewas added before fixing. It fails on current main, passes after this changeDocumentation: not needed