-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Skip flaky test on Windows #35302
[chore] Skip flaky test on Windows #35302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I entirely agree skipping is the right move for now. Slight nit though, I might leave the original issue open in the case of this component finding a maintainer. While we have the component in contrib
it makes sense to keep its issues. If we get to the point of removing it we can go through and close all related issues 👍
If that's agreeable, we can remove the Fix
prefix before the issue number in the PR description.
Another test in the same file failed on Windows:
We can add a skip now or later, whatever's easier |
@crobert-1 let me add the skip for |
**Description:** Since `receiver/googlecloudspanner` is unmaintained I'm opting to simply skip the flaky test on Windows. **Link to tracking Issue:** Workaround for open-telemetry#32397
Description:
Since
receiver/googlecloudspanner
is unmaintained I'm opting to simply skip the flaky test on Windows.Link to tracking Issue:
Workaround for #32397
Testing:
N/A
Documentation:
N/A