-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[choe] replace scraperhelper.NewScraperWithComponentType to scraperhelper.NewScraper as deprecated #35205
Conversation
cmd/otelcontribcol/go.mod
Outdated
@@ -4,7 +4,7 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontrib | |||
|
|||
go 1.22.0 | |||
|
|||
toolchain go1.22.7 | |||
toolchain go1.23.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't update the toolchain version here. (Same comment for other toolchain updates)
cmd/githubgen/go.mod
Outdated
gopkg.in/yaml.v3 v3.0.1 | ||
) | ||
|
||
require github.com/rogpeppe/go-internal v1.12.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share why this dependency is required? I wouldn't have expected a new dependency to be required when the only change is updating existing dependencies, but one of them must require it now?
acc730a
to
2357574
Compare
@crobert-1 So, I recreated the changes by running |
Overlaps with #35215, I think @codeboten wants to merge #35215 first |
sorry @mrasu! i hadnt seen this PR before i started working on my own update core PR to include the changes i made to the processor helper... i think it's almost ready to merge |
@codeboten No worries! close this |
To change an argument of
scraperhelper.NewScraper
,scraperhelper.NewScraperWithComponentType
is introduced in previous version and deprecated in newer version at open-telemetry/opentelemetry-collector#11159.This PR update dependencies by
multimod sync
and replacescraperhelper.NewScraperWithComponentType
toscraperhelper.NewScraper
Link to tracking Issue: open-telemetry/opentelemetry-collector#9473