Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/resourcedetection] Remove processor.resourcedetection.hostCPUModelAndFamilyAsString feature gate #35203

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

ChrsMark
Copy link
Member

Description:

Follows #33077, #29152 and #29462. The feature gate has been stable since v0.101.0.

Link to tracking Issue: Relates to #29025 and to
open-telemetry/semantic-conventions#495

/cc @mx-psi

…CPUModelAndFamilyAsString feature gate

Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark requested review from a team and atoulme September 16, 2024 09:49
@github-actions github-actions bot added the processor/resourcedetection Resource detection processor label Sep 16, 2024
@ChrsMark
Copy link
Member Author

Since this is a cleanup of code I think there is no need for change-log but let me know if that's not true.

@ChrsMark ChrsMark added chore Skip Changelog PRs that do not require a CHANGELOG.md entry labels Sep 16, 2024
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does need a changelog since trying to enable that feature gate will now result in an error

Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark force-pushed the remove_host_cpu_model_family_fg branch from 07f3951 to 668eaea Compare September 16, 2024 10:11
@ChrsMark ChrsMark added processor/resourcedetection Resource detection processor and removed processor/resourcedetection Resource detection processor chore Skip Changelog PRs that do not require a CHANGELOG.md entry labels Sep 16, 2024
@mx-psi mx-psi added Run Windows Enable running windows test on a PR and removed Run Windows Enable running windows test on a PR labels Sep 16, 2024
@mx-psi mx-psi merged commit 1b03346 into open-telemetry:main Sep 16, 2024
155 of 156 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 16, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…CPUModelAndFamilyAsString feature gate (open-telemetry#35203)

Description:

Follows open-telemetry#33077,
open-telemetry#29152
and
open-telemetry#29462.
The feature gate has been stable since v0.101.0.

Link to tracking Issue: Relates to
open-telemetry#29025
and to
open-telemetry/semantic-conventions#495


/cc @mx-psi

---------

Signed-off-by: ChrsMark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/resourcedetection Resource detection processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants